src/parser.cc - Issue 1302893002: Tighten & check the BookmarkScope API contract a bit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/parser.cc

Issue 1302893002: Tighten & check the BookmarkScope API contract a bit. Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/parser.cc

diff --git a/src/parser.cc b/src/parser.cc

index 301bda94c4011987aff1a704a5f2e6f84d79c137..aeb9a3de0589439060bf134d21ec5831819021a6 100644

--- a/src/parser.cc

+++ b/src/parser.cc

@@ -4110,7 +4110,7 @@ FunctionLiteral* Parser::ParseFunctionLiteral(

&expected_property_count, /*CHECK_OK*/ ok,

maybe_bookmark);

- if (bookmark.HasBeenReset()) {

+ if (maybe_bookmark && maybe_bookmark->HasBeenReset()) {

// Trigger eager (re-)parsing, just below this block.

is_lazily_parsed = false;

« no previous file with comments | « no previous file | src/scanner.h » ('j') | src/scanner.h » ('J')