Tighten & check the BookmarkScope API contract a bit.

src/scanner.h

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Features shared by parsing and pre-parsing scanners.
 
 #ifndef V8_SCANNER_H_
 #define V8_SCANNER_H_
 
 #include "src/allocation.h"
@@ skipping 341 matching lines @@
     }
 
    private:
     Scanner* scanner_;
     bool complete_;
   };
 
   // Scoped helper for a re-settable bookmark.
   class BookmarkScope {
    public:
-    explicit BookmarkScope(Scanner* scanner) : scanner_(scanner) {
+    explicit BookmarkScope(Scanner* scanner)
+        : scanner_(scanner), my_bookmark_(false) {
       DCHECK_NOT_NULL(scanner_);
     }
-    ~BookmarkScope() { scanner_->DropBookmark(); }
+    ~BookmarkScope() {
+      if (my_bookmark_) scanner_->DropBookmark();

[rossberg, 2015/08/20 15:45:12]

Hm, this _does_ change the semantics, doesn't it? It looks more correct, though.

[vogelheim, 2015/08/20 16:26:31]

Yes, good observation. But I think the case where this makes a difference
shouldn't happen in practice, so it shouldn't change behaviour overall.

And if the case does happen, this should fix a bug. :)  This is what I
originally meant to implement.

+    }
 
-    bool Set() { return scanner_->SetBookmark(); }
-    void Reset() { scanner_->ResetToBookmark(); }
-    bool HasBeenSet() { return scanner_->BookmarkHasBeenSet(); }
-    bool HasBeenReset() { return scanner_->BookmarkHasBeenReset(); }
+    bool Set() {
+      DCHECK(!my_bookmark_);
+      my_bookmark_ = scanner_->SetBookmark();
+      return my_bookmark_;
+    }
+    void Reset() {
+      DCHECK(my_bookmark_);
+      scanner_->ResetToBookmark();
+    }
+    bool HasBeenSet() {
+      DCHECK(my_bookmark_);
+      return scanner_->BookmarkHasBeenSet();
+    }
+    bool HasBeenReset() {
+      DCHECK(my_bookmark_);
+      return scanner_->BookmarkHasBeenReset();
+    }
 
    private:
     Scanner* scanner_;
+    bool my_bookmark_;  // Did this BookmarkScope set the current bookmark?
 
     DISALLOW_COPY_AND_ASSIGN(BookmarkScope);
   };
 
   // Representation of an interval of source positions.
   struct Location {
     Location(int b, int e) : beg_pos(b), end_pos(e) { }
     Location() : beg_pos(0), end_pos(0) { }
 
     bool IsValid() const {
@@ skipping 401 matching lines @@
   // inside multiline comments.
   bool has_line_terminator_before_next_;
   // Whether there is a multi-line comment that contains a
   // line-terminator after the current token, and before the next.
   bool has_multiline_comment_before_next_;
 };
 
 } }  // namespace v8::internal
 
 #endif  // V8_SCANNER_H_