Issue 1302843004: Use -[NSNumber numberWithDouble:] for doubles

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1302843004: Use -[NSNumber numberWithDouble:] for doubles (Closed)

Created:
5 years, 4 months ago by Mark Mentovai

Modified:
5 years, 4 months ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

More Reviews

Description

Use -[NSNumber numberWithDouble:] for doubles Found by -fsanitize=undefined: [ RUN ] Launchd.CFPropertyToLaunchData_FloatingPoint ../../../util/mac/launchd_test.mm:82:33: runtime error: value 1.79769e+308 is outside the range of representable values of type 'float' [ OK ] Launchd.CFPropertyToLaunchData_FloatingPoint (2 ms) TEST=crashpad_util_test Launchd.CFPropertyToLaunchData_FloatingPoint BUG= R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/5064aeb78477889bebf29b5ef630201b60a84b3e

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	util/mac/launchd_test.mm	View		1 chunk	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Mark Mentovai

5 years, 4 months ago (2015-08-20 13:29:29 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5064aeb78477889bebf29b5ef630201b60a84b3e (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages