Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: handler/crash_report_upload_thread.cc

Issue 1302833002: Fix -Winconsistent-missing-override in CrashReportUploadThread (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Crashpad Authors. All rights reserved. 1 // Copyright 2015 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 } // namespace 138 } // namespace
139 139
140 namespace internal { 140 namespace internal {
141 141
142 class CrashReportUploadHelperThread final : public Thread { 142 class CrashReportUploadHelperThread final : public Thread {
143 public: 143 public:
144 explicit CrashReportUploadHelperThread(CrashReportUploadThread* self) 144 explicit CrashReportUploadHelperThread(CrashReportUploadThread* self)
145 : self_(self) {} 145 : self_(self) {}
146 ~CrashReportUploadHelperThread() override {} 146 ~CrashReportUploadHelperThread() override {}
147 147
148 virtual void ThreadMain() { 148 void ThreadMain() override {
149 self_->ThreadMain(); 149 self_->ThreadMain();
150 } 150 }
151 151
152 private: 152 private:
153 CrashReportUploadThread* self_; 153 CrashReportUploadThread* self_;
154 154
155 DISALLOW_COPY_AND_ASSIGN(CrashReportUploadHelperThread); 155 DISALLOW_COPY_AND_ASSIGN(CrashReportUploadHelperThread);
156 }; 156 };
157 157
158 } // namespace internal 158 } // namespace internal
(...skipping 212 matching lines...) Expand 10 before | Expand all | Expand 10 after
371 http_transport->SetTimeout(60.0); // 1 minute. 371 http_transport->SetTimeout(60.0); // 1 minute.
372 372
373 if (!http_transport->ExecuteSynchronously(response_body)) { 373 if (!http_transport->ExecuteSynchronously(response_body)) {
374 return UploadResult::kRetry; 374 return UploadResult::kRetry;
375 } 375 }
376 376
377 return UploadResult::kSuccess; 377 return UploadResult::kSuccess;
378 } 378 }
379 379
380 } // namespace crashpad 380 } // namespace crashpad
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698