Issue 1302803003: [api] Relax CHECK for ArrayBuffer API abuse

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1302803003: [api] Relax CHECK for ArrayBuffer API abuse (Closed)

Created:
5 years, 4 months ago by adamk

Modified:
5 years, 4 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev, vogelheim

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

[api] Relax CHECK for ArrayBuffer API abuse Zero-length ArrayBuffers are allowed to have NULL backing stores. BUG=522496 LOG=n Committed: https://crrev.com/de26ce051f5b5062f71bf16327c9d1e26ead9823 Cr-Commit-Position: refs/heads/master@{#30259}

Patch Set 1 #

Patch Set 2 : Add test #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
	M	src/api.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	A +	test/mjsunit/regress/regress-crbug-522496.js	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1302803003/2 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1302803003/2

5 years, 4 months ago (2015-08-19 21:24:59 UTC) #5

commit-bot: I haz the power

5 years, 4 months ago (2015-08-19 21:53:30 UTC) #7

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/de26ce051f5b5062f71bf16327c9d1e26ead9823
Cr-Commit-Position: refs/heads/master@{#30259}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages