Source/modules/mediastream/MediaDevices.cpp - Issue 1302793002: Refactor "options" argument to getUserMedia to be a dictionary

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/mediastream/MediaDevices.cpp

Issue 1302793002: Refactor "options" argument to getUserMedia to be a dictionary (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/mediastream/MediaDevices.h ('k') | Source/modules/mediastream/MediaDevices.idl » ('j') | Source/modules/mediastream/UserMediaRequest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/mediastream/MediaDevices.cpp

diff --git a/Source/modules/mediastream/MediaDevices.cpp b/Source/modules/mediastream/MediaDevices.cpp

index 66cd9770b0cc9e28f7b5ed5395f866c0ff62de64..31510f1e29a291ae7d764d35590b3c261d0b1c94 100644

--- a/Source/modules/mediastream/MediaDevices.cpp

+++ b/Source/modules/mediastream/MediaDevices.cpp

@@ -12,6 +12,7 @@

#include "core/dom/Document.h"

#include "core/dom/ExceptionCode.h"

#include "modules/mediastream/MediaStream.h"

+#include "modules/mediastream/MediaStreamConstraints.h"

#include "modules/mediastream/NavigatorMediaStream.h"

#include "modules/mediastream/NavigatorUserMediaErrorCallback.h"

#include "modules/mediastream/NavigatorUserMediaSuccessCallback.h"

@@ -86,7 +87,7 @@ private:

} // namespace

-ScriptPromise MediaDevices::getUserMedia(ScriptState* scriptState, const Dictionary& options, ExceptionState& exceptionState)

+ScriptPromise MediaDevices::getUserMedia(ScriptState* scriptState, const MediaStreamConstraints& options, ExceptionState& exceptionState)

{

ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);