Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2541)

Unified Diff: chrome/browser/resources/chromeos/chromevox/host/chrome/braille_background.js

Issue 1302763002: Add tests for braille commands. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@js2gtesterr
Patch Set: Document gn template args, rename extra_gen_files to gen_include_files Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/chromevox/host/chrome/braille_background.js
diff --git a/chrome/browser/resources/chromeos/chromevox/host/chrome/braille_background.js b/chrome/browser/resources/chromeos/chromevox/host/chrome/braille_background.js
index 9ce5807e7fead023eac725c637578d22c5bcabb4..a1536ecbb18dd3b64214fa00576f6f3a1f4c13fd 100644
--- a/chrome/browser/resources/chromeos/chromevox/host/chrome/braille_background.js
+++ b/chrome/browser/resources/chromeos/chromevox/host/chrome/braille_background.js
@@ -8,9 +8,9 @@
goog.provide('cvox.BrailleBackground');
-goog.require('cvox.AbstractBraille');
goog.require('cvox.BrailleDisplayManager');
goog.require('cvox.BrailleInputHandler');
+goog.require('cvox.BrailleInterface');
goog.require('cvox.BrailleKeyEvent');
goog.require('cvox.BrailleTranslatorManager');
goog.require('global');
@@ -24,12 +24,11 @@ goog.require('global');
* (for mocking in tests).
* @param {cvox.BrailleTranslatorManager=} opt_translatorManagerForTest
* Braille translator manager (for mocking in tests)
- * @extends {cvox.AbstractBraille}
+ * @implements {cvox.BrailleInterface}
*/
cvox.BrailleBackground = function(opt_displayManagerForTest,
opt_inputHandlerForTest,
opt_translatorManagerForTest) {
- goog.base(this);
/**
* @type {!cvox.BrailleTranslatorManager}
* @private*/
@@ -60,7 +59,6 @@ cvox.BrailleBackground = function(opt_displayManagerForTest,
new cvox.BrailleInputHandler(this.translatorManager_);
this.inputHandler_.init();
};
-goog.inherits(cvox.BrailleBackground, cvox.AbstractBraille);
/** @override */
@@ -69,13 +67,6 @@ cvox.BrailleBackground.prototype.write = function(params) {
};
-/** @override */
-cvox.BrailleBackground.prototype.setCommandListener = function(func) {
- // TODO(plundblad): Implement when the background page handles commands
- // as well.
-};
-
-
/**
* @return {cvox.BrailleTranslatorManager} The translator manager used by this
* instance.

Powered by Google App Engine
This is Rietveld 408576698