Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 1302703002: Fix flakiness of fast/forms/submit-change-fragment.html. (Closed)

Created:
5 years, 4 months ago by tkent
Modified:
5 years, 4 months ago
Reviewers:
keishi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix flakiness of fast/forms/submit-change-fragment.html. The test timed out in the following case: 1. document.location.search = "?n=v" requests a navigation. 2. Before the navigation happens, onload handler runTest() is executed. 3. document.forms.f.submit() navigates to ".../submit-change-fragment.html?n=v#firstaction" 4. Because the original document was ".../submit-change-fragment.html", onhashchange handler is NOT called. 5. No one calls testRunner.notifyDone(). This CL moves "?n=v" setting code to runTest(), and do early return to avoid the form submission without "?n=v". BUG=521860 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200798

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/forms/submit-change-fragment.html View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tkent
Keishi, please review this.
5 years, 4 months ago (2015-08-19 04:21:00 UTC) #2
keishi
lgtm
5 years, 4 months ago (2015-08-19 04:24:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1302703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1302703002/1
5 years, 4 months ago (2015-08-19 04:30:53 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 05:10:04 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200798

Powered by Google App Engine
This is Rietveld 408576698