Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 1302643002: Update Durable Storage API method signature (Closed)

Created:
5 years, 4 months ago by dgrogan
Modified:
5 years, 4 months ago
Reviewers:
kinuko, jsbell
CC:
blink-reviews, abarth-chromium, kinuko+fileapi, nhiroki, tzik
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Update Durable Storage API method signature Instead of returning a permission string, requestPersistent() was recently changed to return a boolean representing the value of the default box. This is an experimental API only exposed behind a flag. The spec is at https://storage.spec.whatwg.org/ BUG=482814 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200795

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix assert string #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -9 lines) Patch
M LayoutTests/http/tests/storage/durability-basics.html View 1 1 chunk +3 lines, -4 lines 0 comments Download
M Source/modules/quota/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/quota/StorageManager.cpp View 4 chunks +25 lines, -4 lines 0 comments Download
M Source/modules/quota/StorageManager.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
dgrogan
Josh, could you review this?
5 years, 4 months ago (2015-08-19 00:53:31 UTC) #2
jsbell
lgtm with a string nit can you update the CL description to mention that it's ...
5 years, 4 months ago (2015-08-19 01:04:43 UTC) #3
dgrogan
Kinuko, could you review this? Josh reviewed the code. I added him to the OWNERS ...
5 years, 4 months ago (2015-08-19 01:12:34 UTC) #5
kinuko
Sure. lgtm
5 years, 4 months ago (2015-08-19 01:15:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1302643002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1302643002/20001
5 years, 4 months ago (2015-08-19 02:25:59 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/108739)
5 years, 4 months ago (2015-08-19 03:07:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1302643002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1302643002/20001
5 years, 4 months ago (2015-08-19 03:16:38 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 04:38:33 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200795

Powered by Google App Engine
This is Rietveld 408576698