Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2743)

Unified Diff: chrome/browser/resources/file_manager/common/js/util.js

Issue 130263003: Remove fullPath from util.isSameEntry(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/file_manager/background/js/volume_manager.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/file_manager/common/js/util.js
diff --git a/chrome/browser/resources/file_manager/common/js/util.js b/chrome/browser/resources/file_manager/common/js/util.js
index 0230c7856d52cd7996685ff842dd9bd386700a2c..eafc334ff3622ddfa24c60ff1877f49fb1e12f01 100644
--- a/chrome/browser/resources/file_manager/common/js/util.js
+++ b/chrome/browser/resources/file_manager/common/js/util.js
@@ -1106,11 +1106,14 @@ util.createFileError = function(code) {
util.isSameEntry = function(entry1, entry2) {
// Currently, we can assume there is only one root.
// When we support multi-file system, we need to look at filesystem, too.
- return (entry1 && entry2 && entry1.fullPath === entry2.fullPath) ||
+ return (entry1 && entry2 && entry1.toURL() === entry2.toURL()) ||
(!entry1 && !entry2);
};
/**
+ * TODO(mtomasz, yoshiki): Deprecated. Only used in directory_tree.js. Will
+ * be removed soon.
+ *
* @param {Entry|Object} parent The parent entry. Can be a fake.
* @param {Entry|Object} child The child entry. Can be a fake.
* @return {boolean} True if parent entry is actualy the parent of the child
« no previous file with comments | « chrome/browser/resources/file_manager/background/js/volume_manager.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698