Use portable code for family names with DirectWrite.

Use portable code for family names with DirectWrite.

IDWriteFamily::GetFamilyNames appears to be 'helpful' and removes
parts of family names that look like style names. Since the iterator
is supposed to return the actual names and not just the name the
platform thinks the name is (as getFamilyName does), try returning
the raw names when possible.

BUG=skia:4217
Committed: https://skia.googlesource.com/skia/+/f05271581fc6204c2b7ccf146af5d02eec27e670

[bungeman-skia, 2015-08-18 15:42:36]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-08-18 15:42:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1302573002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1302573002/1

[bungeman-skia, 2015-08-18 15:42:54]

The CQ bit was unchecked by bungeman@google.com

[bungeman-skia, 2015-08-18 16:16:46]

bungeman@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2015-08-18 16:21:11]

lgtm

[bungeman-skia, 2015-08-18 16:33:25]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2015-08-18 16:33:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1302573002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1302573002/1

[commit-bot: I haz the power, 2015-08-18 16:34:10]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f05271581fc6204c2b7ccf146af5d02eec27e670

[drott, 2015-08-19 08:28:10]

drott@chromium.org changed reviewers:
+ drott@chromium.org

[drott, 2015-08-19 08:28:11]

Great! Thanks for the very quick fix! The tests are working now on Windows. Just
one remark regarding the non-iterator method.

https://codereview.chromium.org/1302573002/diff/1/src/ports/SkTypeface_win_dw...
File src/ports/SkTypeface_win_dw.cpp (right):

https://codereview.chromium.org/1302573002/diff/1/src/ports/SkTypeface_win_dw...
src/ports/SkTypeface_win_dw.cpp:30: SkTScopedComPtr<IDWriteLocalizedStrings>
familyNames;
How about here? Should this implementation perhaps just return the first from
the list that the iterator produces?

[bungeman-skia, 2015-08-19 14:10:49]

On 2015/08/19 08:28:11, drott wrote:
> Great! Thanks for the very quick fix! The tests are working now on Windows.
Just
> one remark regarding the non-iterator method.
> 
>
https://codereview.chromium.org/1302573002/diff/1/src/ports/SkTypeface_win_dw...
> File src/ports/SkTypeface_win_dw.cpp (right):
> 
>
https://codereview.chromium.org/1302573002/diff/1/src/ports/SkTypeface_win_dw...
> src/ports/SkTypeface_win_dw.cpp:30: SkTScopedComPtr<IDWriteLocalizedStrings>
> familyNames;
> How about here? Should this implementation perhaps just return the first from
> the list that the iterator produces?

I don't think so. getFamilyName is supposed to return the family name as the
underlying system thinks of it, which may or may not be a name in the font
itself. For example, on GDI this will return 'Helvetica' for the 'Arial' font if
it was originally requested as 'Helvetica'. With FontConfig this will return
some name of the font as reported by the match, which might be supplied by the
user. Also, getFamilyName is the name as requested in the locale of the request,
which may also be a different thing.