Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 1302543002: Support calling BackgroundSyncProviderThreadProxy::GetThreadInstance after the worker has stopped (Closed)

Created:
5 years, 4 months ago by jkarlin
Modified:
5 years, 4 months ago
Reviewers:
jsbell
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, jam, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, jkarlin+watch_chromium.org, darin-cc_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support calling BackgroundSyncProviderThreadProxy::GetThreadInstance after the worker has stopped This fixes the crash introduced by https://codereview.chromium.org/1290073003/ Crashes: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=http%2Ftests%2Fcache%2Fcached-main-resource.html BUG=502214 Committed: https://crrev.com/0b5b16d3a9ac125e720843a4a2fd1dd593e5751b Cr-Commit-Position: refs/heads/master@{#343953}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M content/child/background_sync/background_sync_provider_thread_proxy.cc View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
jkarlin
jsbell: PTAL at this additional crash fix.
5 years, 4 months ago (2015-08-18 14:58:23 UTC) #2
jsbell
lgtm
5 years, 4 months ago (2015-08-18 16:29:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1302543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1302543002/1
5 years, 4 months ago (2015-08-18 17:41:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-18 17:45:58 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 17:46:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0b5b16d3a9ac125e720843a4a2fd1dd593e5751b
Cr-Commit-Position: refs/heads/master@{#343953}

Powered by Google App Engine
This is Rietveld 408576698