Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: content/browser/renderer_host/media/video_capture_device_impl.h

Issue 130253002: Attempt to fixed crash on stop mirroring by stopping render thread on a worker thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/video_capture_device_impl.h
diff --git a/content/browser/renderer_host/media/video_capture_device_impl.h b/content/browser/renderer_host/media/video_capture_device_impl.h
index d2c03f50a2cd1ad51f6b6f60836b3260093ace42..56bf1e0eac8dbd564f489de78df3146b33c01030 100644
--- a/content/browser/renderer_host/media/video_capture_device_impl.h
+++ b/content/browser/renderer_host/media/video_capture_device_impl.h
@@ -119,7 +119,8 @@ class VideoCaptureMachine {
const scoped_refptr<ThreadSafeCaptureOracle>& oracle_proxy) = 0;
// Stops capturing. Must be run on the UI BrowserThread.
- virtual void Stop() = 0;
+ // |callback| is invoked after the capturing has stopped.
+ virtual void Stop(const base::Closure& callback) = 0;
protected:
bool started_;

Powered by Google App Engine
This is Rietveld 408576698