Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 1302513006: Reland of Add a library for running external commands, providing timeouts and test injection. (Closed)

Created:
5 years, 4 months ago by dogben
Modified:
5 years, 4 months ago
Reviewers:
jcgregorio, rmistry
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/buildbot@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reland of Add a library for running external commands, providing timeouts and test injection. (patchset #1 id:1 of https://codereview.chromium.org/1295043002/ ) Reason for revert: Fixed bug in original code - see patchset #2. Original issue's description: > Revert of Add a library for running external commands, providing timeouts and test injection. (patchset #2 id:40001 of https://codereview.chromium.org/1290913004/ ) > > Reason for revert: > CT Chromium Perf tasks are failing with: > > E0815 11:07:22.649344 13091 exec.go:193] Command exited with invalid argument: python /b/skia-repo/go/src/go.skia.org/infra/ct/py/sync_skia_in_chrome.py --destination=/b/storage/chromium_builds/linux_base --fetch_target=chromium --chrome_revision=6ae54795f6d077e31f4fb42540ead46f4141f2bb --skia_revision=fb28cd2b13d76c324570341e1155aaadc1b532b6 > > Original issue's description: > > Add a library for running external commands, providing timeouts and test injection. > > > > BUG=skia:4106 > > > > Committed: https://skia.googlesource.com/buildbot/+/b65fde6749a3e060938cd280c7e281e29516edc1 > > TBR=jcgregorio@google.com,benjaminwagner@google.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=skia:4106 > > Committed: https://skia.googlesource.com/buildbot/+/ac6c1292955c888d35f6c01cf97d3b6ff4029424 BUG=skia:4106 Committed: https://skia.googlesource.com/buildbot/+/a12e89205d4145b4da14b0a7d5b95b15b029ada9

Patch Set 1 #

Patch Set 2 : Fix bug with nil io.Writer. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+547 lines, -85 lines) Patch
M ct/go/adb/adb.go View 1 3 chunks +3 lines, -4 lines 0 comments Download
M ct/go/util/util.go View 1 2 chunks +17 lines, -59 lines 0 comments Download
A go/exec/exec.go View 1 1 chunk +235 lines, -0 lines 0 comments Download
A go/exec/exec_test.go View 1 1 chunk +289 lines, -0 lines 0 comments Download
M go/util/command.go View 1 1 chunk +3 lines, -22 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
dogben
Created Reland of Add a library for running external commands, providing timeouts and test injection.
5 years, 4 months ago (2015-08-18 20:05:26 UTC) #1
dogben
PTAL
5 years, 4 months ago (2015-08-18 20:08:55 UTC) #2
rmistry
lgtm
5 years, 4 months ago (2015-08-19 12:41:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1302513006/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1302513006/140001
5 years, 4 months ago (2015-08-19 19:49:06 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:140001) as https://skia.googlesource.com/buildbot/+/a12e89205d4145b4da14b0a7d5b95b15b029ada9
5 years, 4 months ago (2015-08-19 19:51:05 UTC) #6
rmistry
A revert of this CL (patchset #2 id:140001) has been created in https://codereview.chromium.org/1299493004/ by rmistry@google.com. ...
5 years, 4 months ago (2015-08-19 20:11:33 UTC) #7
rmistry
5 years, 4 months ago (2015-08-19 20:18:00 UTC) #8
Message was sent while issue was closed.
On 2015/08/19 20:11:33, rmistry wrote:
> A revert of this CL (patchset #2 id:140001) has been created in
> https://codereview.chromium.org/1299493004/ by mailto:rmistry@google.com.
> 
> The reason for reverting is: CT Perf tasks are immediately failing:
>
https://uberchromegw.corp.google.com/i/skia-ct-master/run_chromium_perf_on_wo...
> 
> It is likely unrelated to this CL but I am going to try reverting it and
> rerunning to see what happens..

It appears to be working after the revert:
https://uberchromegw.corp.google.com/i/skia-ct-master/run_chromium_perf_on_wo...

Sorry I could not find more useful logs. I am not sure why whichever error
caused it to crash the first time does not show up.

Powered by Google App Engine
This is Rietveld 408576698