Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 1302513004: [simd.js] Macro-ize more SIMD code (2). (Closed)

Created:
5 years, 4 months ago by bbudge
Modified:
5 years, 4 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[simd.js] Macro-ize more SIMD code. Use macros for SIMD get/set_lane, and print fns. LOG=N BUG=v8:4124 Committed: https://crrev.com/f33d5717eb49cdc23a1780af69554fd9c7f3ecc8 Cr-Commit-Position: refs/heads/master@{#30239}

Patch Set 1 #

Patch Set 2 : #undef what you #define #

Patch Set 3 : 2 more #undefs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -220 lines) Patch
M src/objects-inl.h View 1 2 3 chunks +69 lines, -166 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +26 lines, -54 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
bbudge
I split this off of https://codereview.chromium.org/1294513004/ to simplify that review. That CL will depend on ...
5 years, 4 months ago (2015-08-18 17:20:55 UTC) #2
Jarin
lgtm
5 years, 4 months ago (2015-08-18 19:50:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1302513004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1302513004/40001
5 years, 4 months ago (2015-08-18 20:13:04 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-08-18 20:39:48 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 20:40:06 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f33d5717eb49cdc23a1780af69554fd9c7f3ecc8
Cr-Commit-Position: refs/heads/master@{#30239}

Powered by Google App Engine
This is Rietveld 408576698