Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1302503003: Fix transformed stroke width in GrAALinearizingConvexPathRenderer. (Closed)

Created:
5 years, 4 months ago by ethannicholas
Modified:
5 years, 4 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix transformed stroke width in GrAALinearizingConvexPathRenderer. BUG=520476 Committed: https://skia.googlesource.com/skia/+/fea7763140ba74b78f2c30028452e250140b6f21

Patch Set 1 #

Patch Set 2 : added an assert #

Total comments: 1

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -5 lines) Patch
A gm/scaledstrokes.cpp View 1 2 3 4 5 1 chunk +84 lines, -0 lines 0 comments Download
M src/gpu/GrAAConvexTessellator.cpp View 1 2 3 2 chunks +8 lines, -3 lines 0 comments Download
M src/gpu/GrAALinearizingConvexPathRenderer.cpp View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 23 (12 generated)
ethannicholas
5 years, 4 months ago (2015-08-18 14:45:19 UTC) #2
ethannicholas
5 years, 4 months ago (2015-08-18 16:17:00 UTC) #3
egdaniel
lgtm with nit https://codereview.chromium.org/1302503003/diff/20001/gm/scaledstrokes.cpp File gm/scaledstrokes.cpp (right): https://codereview.chromium.org/1302503003/diff/20001/gm/scaledstrokes.cpp#newcode27 gm/scaledstrokes.cpp:27: void drawPath(int size, SkCanvas* canvas, SkPaint ...
5 years, 4 months ago (2015-08-18 16:25:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1302503003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1302503003/40001
5 years, 4 months ago (2015-08-18 17:05:34 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86_64-Release-Trybot/builds/2752)
5 years, 4 months ago (2015-08-18 17:10:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1302503003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1302503003/60001
5 years, 4 months ago (2015-08-19 15:58:00 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/2838)
5 years, 4 months ago (2015-08-19 16:01:25 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1302503003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1302503003/80001
5 years, 4 months ago (2015-08-19 17:23:51 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/2845)
5 years, 4 months ago (2015-08-19 17:31:19 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1302503003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1302503003/100001
5 years, 4 months ago (2015-08-19 19:01:46 UTC) #22
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 19:09:15 UTC) #23
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/fea7763140ba74b78f2c30028452e250140b6f21

Powered by Google App Engine
This is Rietveld 408576698