content/browser/renderer_host/media/audio_input_renderer_host.cc - Issue 1302423006: Ensure that data is not overwritten in the audio input shared memory ring buffer that sits on the b…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/media/audio_input_renderer_host.cc

Issue 1302423006: Ensure that data is not overwritten in the audio input shared memory ring buffer that sits on the b… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code review. Unit test improvement. Changed read verification algorithm. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/sync_socket.h ('k') | content/browser/renderer_host/media/audio_input_sync_writer.h » ('j') | content/browser/renderer_host/media/audio_input_sync_writer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/media/audio_input_renderer_host.cc

diff --git a/content/browser/renderer_host/media/audio_input_renderer_host.cc b/content/browser/renderer_host/media/audio_input_renderer_host.cc

index 2692f74dc99895a725c6c585be4987fd98cfe7f5..70898052f0467abe7ea587f700c4ed8d1a97ea4f 100644

--- a/content/browser/renderer_host/media/audio_input_renderer_host.cc

+++ b/content/browser/renderer_host/media/audio_input_renderer_host.cc

@@ -364,7 +364,8 @@ void AudioInputRendererHost::DoCreateStream(

}

scoped_ptr<AudioInputSyncWriter> writer(new AudioInputSyncWriter(

- &entry->shared_memory, entry->shared_memory_segment_count, audio_params));

+ entry->shared_memory.memory(), entry->shared_memory.requested_size(),

+ entry->shared_memory_segment_count, audio_params));

if (!writer->Init()) {

SendErrorMessage(stream_id, SYNC_WRITER_INIT_FAILED);