Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1367)

Unified Diff: content/browser/renderer_host/media/audio_input_sync_writer.h

Issue 1302423006: Ensure that data is not overwritten in the audio input shared memory ring buffer that sits on the b… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Code review + rebase. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/audio_input_sync_writer.h
diff --git a/content/browser/renderer_host/media/audio_input_sync_writer.h b/content/browser/renderer_host/media/audio_input_sync_writer.h
index cc6c0f248e5e7568681b19ca35a4eb51bc4fdb89..25358f9fce576a22f242c88e549f46dc5a8094c7 100644
--- a/content/browser/renderer_host/media/audio_input_sync_writer.h
+++ b/content/browser/renderer_host/media/audio_input_sync_writer.h
@@ -70,6 +70,14 @@ class AudioInputSyncWriter : public media::AudioInputController::SyncWriter {
// Increasing ID used for audio buffers correct sequence at read side.
uint32_t next_buffer_id_;
+ // Keeps track of number of expected buffer reads on the renderer side.
+ int expected_buffer_reads_;
+
+ // Counts the total number of buffer read verifictions and the number of
+ // timeouts when verifying.
tommi (sloooow) - chröme 2015/08/28 13:43:06 is it possible to point to some design? As is, it
+ size_t read_verification_count_;
+ size_t read_verification_timeout_count_;
+
// Vector of audio buses allocated during construction and deleted in the
// destructor.
ScopedVector<media::AudioBus> audio_buses_;

Powered by Google App Engine
This is Rietveld 408576698