Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 1302423006: Ensure that data is not overwritten in the audio input shared memory ring buffer that sits on the b… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Code review. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « media/audio/audio_input_device.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index c998f475a1dc9fbaf106f4dbae5951cd0794560c..b6ee1e5d2e81ebdc610602657b5104af7b765464 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -16639,6 +16639,26 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<summary>Bits per channel of HTML5 audio sample data.</summary>
</histogram>
+<histogram name="Media.AudioCapturerAudioGlitches" enum="AudioGlitchResult">
+ <owner>grunell@chromium.org</owner>
+ <summary>
+ Whether input audio glitches due to input audio read verifications that
+ missed dealine are detected. Sampled when a low-latency input audio stream
+ is destructed.
+ </summary>
+</histogram>
+
+<histogram name="Media.AudioCapturerMissedReadDeadline" units="%">
+ <owner>grunell@chromium.org</owner>
+ <summary>
+ The number of input audio read verifications that missed its realtime
jwd 2015/09/04 19:20:34 Is it the number or the % as the units suggests?
Henrik Grunell 2015/09/06 12:45:08 %. Fixed.
+ deadline. The read verification ensures that data is not overwritten in the
+ shared ring buffer on the browser/renderer boundary before read by the other
+ side. Missing the deadline means that the reading side hasn't read data in
+ time. Reported at the destruction of low-latency audio input stream.
+ </summary>
+</histogram>
+
<histogram name="Media.AudioChannelLayout" enum="ChannelLayout">
<owner>dalecurtis@chromium.org</owner>
<summary>Audio channel layout in HTML5 media.</summary>
@@ -16744,6 +16764,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<histogram name="Media.AudioTrackProcessingStates"
enum="AudioTrackProcessingStates">
+ <owner>grunell@chromium.org</owner>
<summary>
State of the media stream audio track processing, sampled once during the
life time of a MediaStreamAudioProcessor.
« no previous file with comments | « media/audio/audio_input_device.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698