Source/platform/image-encoders/skia/WEBPImageEncoder.h - Issue 1302423004: Support lossy and lossless <canvas>.toDataURL for webp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/image-encoders/skia/WEBPImageEncoder.h

Issue 1302423004: Support lossy and lossless <canvas>.toDataURL for webp (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/canvas/toDataURL-supportedTypes.html ('K') | « Source/platform/graphics/ImageBuffer.cpp ('k') | Source/platform/image-encoders/skia/WEBPImageEncoder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/image-encoders/skia/WEBPImageEncoder.h

diff --git a/Source/platform/image-encoders/skia/WEBPImageEncoder.h b/Source/platform/image-encoders/skia/WEBPImageEncoder.h

index 3a0e9c2df4735161dceeeb3f66c98b0315c91583..dd7d74f36f3a7e859e0f001d412c489ac766c62f 100644

--- a/Source/platform/image-encoders/skia/WEBPImageEncoder.h

+++ b/Source/platform/image-encoders/skia/WEBPImageEncoder.h

@@ -39,8 +39,11 @@ struct ImageDataBuffer;

class WEBPImageEncoder {

public:

+ // For callers: control the compression mode: lossy or lossless.

+ enum Mode { Default = 0, Lossy = Default, Lossless };

// Encode the input data with a compression quality in [0-100].

- static bool encode(const ImageDataBuffer&, int quality, Vector<unsigned char>*);

+ static bool encode(const ImageDataBuffer&, int quality, Vector<unsigned char>*, Mode = Default);

// For callers: provide a reasonable compression quality default.

enum Quality { DefaultCompressionQuality = 80 };