Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1302413006: Unify ElementsAccessor Array Builtins (Closed)

Created:
5 years, 3 months ago by Camillo Bruni
Modified:
5 years, 3 months ago
Reviewers:
mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@2015-08-28_elements_accessor_unshift
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

ElementsAccessor Array Builtins Cleanup Repeat the same signatures for future refactoring BUG= Committed: https://crrev.com/fb44484ffddf461923ffc9390c1dff632e188ff4 Cr-Commit-Position: refs/heads/master@{#30532}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -40 lines) Patch
M src/builtins.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/elements.h View 3 chunks +3 lines, -6 lines 0 comments Download
M src/elements.cc View 7 chunks +24 lines, -31 lines 0 comments Download

Depends on Patchset:

Issue 1322803002 Patch 200001

Dependent Patchsets:

Issue 1317053006 Patch 1
Issue 1317053006 Patch 20001
Issue 1317053006 Patch 40001
Issue 1317053006 Patch 60001

Messages

Total messages: 12 (4 generated)
Camillo Bruni
PTAL
5 years, 3 months ago (2015-09-01 13:18:18 UTC) #2
Camillo Bruni
5 years, 3 months ago (2015-09-01 17:34:00 UTC) #3
mvstanton
lgtm
5 years, 3 months ago (2015-09-01 21:25:28 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1302413006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1302413006/1
5 years, 3 months ago (2015-09-02 06:08:21 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-02 06:31:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1302413006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1302413006/1
5 years, 3 months ago (2015-09-02 06:40:53 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-02 06:42:04 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 06:42:21 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/fb44484ffddf461923ffc9390c1dff632e188ff4
Cr-Commit-Position: refs/heads/master@{#30532}

Powered by Google App Engine
This is Rietveld 408576698