Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1302363004: CSP: Suppress violation reports for extension resources. (Closed)

Created:
5 years, 3 months ago by Mike West
Modified:
5 years, 3 months ago
CC:
blink-reviews, mkwst+watchlist-csp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

CSP: Suppress violation reports for extension resources. We should never get to a point where a `chrome-extension:` resource shows up in the stack trace for a blocked resource. That said, we're apparently hitting that scenario somewhat often. This patch at least ensures that our brokenness isn't spamming reporting endpoints, and revealing the extensions that users have installed to the site owners. BUG=524356 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201969

Patch Set 1 #

Total comments: 1

Patch Set 2 : Oops. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M Source/core/frame/csp/ContentSecurityPolicy.cpp View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mike West
WDYT, Jochen? It's not clear to me how to write a good test for this, ...
5 years, 3 months ago (2015-09-09 09:08:17 UTC) #2
Mike West
https://codereview.chromium.org/1302363004/diff/1/Source/core/frame/csp/ContentSecurityPolicy.cpp File Source/core/frame/csp/ContentSecurityPolicy.cpp (right): https://codereview.chromium.org/1302363004/diff/1/Source/core/frame/csp/ContentSecurityPolicy.cpp#newcode750 Source/core/frame/csp/ContentSecurityPolicy.cpp:750: if (!violationData.sourceFile().isEmpty() && SchemeRegistry::schemeShouldBypassContentSecurityPolicy(violationData.sourceFile().protocol()) Ha, I'm an idiot. Pretend ...
5 years, 3 months ago (2015-09-09 09:18:18 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 3 months ago (2015-09-09 09:28:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1302363004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1302363004/20001
5 years, 3 months ago (2015-09-09 09:55:13 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 10:50:39 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201969

Powered by Google App Engine
This is Rietveld 408576698