Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: source/libvpx/vpx_dsp/arm/vpx_convolve_neon.c

Issue 1302353004: libvpx: Pull from upstream (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/libvpx.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « source/libvpx/vpx_dsp/arm/vpx_convolve8_neon_asm.asm ('k') | source/libvpx/vpx_dsp/bitreader.c » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: source/libvpx/vpx_dsp/arm/vpx_convolve_neon.c
diff --git a/source/libvpx/vpx_dsp/arm/vpx_convolve_neon.c b/source/libvpx/vpx_dsp/arm/vpx_convolve_neon.c
index 2c0f7e9e7e1f8f3fa8782860a0d9be666de94600..1506ce6203de21ade9449453b47c94237cfa608b 100644
--- a/source/libvpx/vpx_dsp/arm/vpx_convolve_neon.c
+++ b/source/libvpx/vpx_dsp/arm/vpx_convolve_neon.c
@@ -8,6 +8,8 @@
* be found in the AUTHORS file in the root of the source tree.
*/
+#include <assert.h>
+
#include "./vpx_dsp_rtcd.h"
#include "vpx_dsp/vpx_dsp_common.h"
#include "vpx_ports/mem.h"
@@ -25,14 +27,8 @@ void vpx_convolve8_neon(const uint8_t *src, ptrdiff_t src_stride,
// Account for the vertical phase needing 3 lines prior and 4 lines post
int intermediate_height = h + 7;
- if (x_step_q4 != 16 || y_step_q4 != 16) {
- vpx_convolve8_c(src, src_stride,
- dst, dst_stride,
- filter_x, x_step_q4,
- filter_y, y_step_q4,
- w, h);
- return;
- }
+ assert(y_step_q4 == 16);
+ assert(x_step_q4 == 16);
/* Filter starting 3 lines back. The neon implementation will ignore the
* given height and filter a multiple of 4 lines. Since this goes in to
@@ -59,14 +55,8 @@ void vpx_convolve8_avg_neon(const uint8_t *src, ptrdiff_t src_stride,
DECLARE_ALIGNED(8, uint8_t, temp[64 * 72]);
int intermediate_height = h + 7;
- if (x_step_q4 != 16 || y_step_q4 != 16) {
- vpx_convolve8_avg_c(src, src_stride,
- dst, dst_stride,
- filter_x, x_step_q4,
- filter_y, y_step_q4,
- w, h);
- return;
- }
+ assert(y_step_q4 == 16);
+ assert(x_step_q4 == 16);
/* This implementation has the same issues as above. In addition, we only want
* to average the values after both passes.
« no previous file with comments | « source/libvpx/vpx_dsp/arm/vpx_convolve8_neon_asm.asm ('k') | source/libvpx/vpx_dsp/bitreader.c » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698