tests/compiler/dart2js/mirrors_test.dart - Issue 1302333006: Support metadata on patches.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/compiler/dart2js/mirrors_test.dart

Issue 1302333006: Support metadata on patches. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Remove partial renaming Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/compiler/dart2js/mirrors_test.dart

diff --git a/tests/compiler/dart2js/mirrors_test.dart b/tests/compiler/dart2js/mirrors_test.dart

index 2c7b09fe0867b104215f2a6ba43a927287d0c88d..7d3c48cb61ff93491c353a2ec92ece6243b3c3e6 100644

--- a/tests/compiler/dart2js/mirrors_test.dart

+++ b/tests/compiler/dart2js/mirrors_test.dart

@@ -183,7 +183,8 @@ void testFoo(MirrorSystem system, LibraryMirror helperLibrary,

Expect.isTrue(metadata is InstanceMirror);

Expect.isFalse(metadata.hasReflectee);

Expect.throws(() => metadata.reflectee, (_) => true);

- Expect.isTrue(metadata is CommentInstanceMirror);

+ Expect.isTrue(metadata is CommentInstanceMirror,

+ "Unexpected metadata: $metadata");

Expect.equals(commentType.originalDeclaration, metadata.type);

Expect.isTrue(metadata.isDocComment);

Expect.stringEquals(