Adds test coverage for 521663

Adds test coverage for 521663

BUG=521663
TEST=this is a test only change
r=japhet@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201818

[sky, 2015-09-02 23:32:26]

sky@chromium.org changed reviewers:
+ japhet@chromium.org

[sky, 2015-09-02 23:33:15]

This triggers the crash that I fixed here:
https://codereview.chromium.org/1298643003 . I had to get the document through
the initial load, and not done, in order to trigger the cras.

https://codereview.chromium.org/1302333003/diff/1/Source/web/tests/WebFrameTe...
File Source/web/tests/WebFrameTest.cpp (right):

https://codereview.chromium.org/1302333003/diff/1/Source/web/tests/WebFrameTe...
Source/web/tests/WebFrameTest.cpp:7037:
Platform::current()->unitTestSupport()->serveAsynchronousMockedRequests();
This triggers a presubmit hook that fails. I had to use bypass-hooks to upload.
What should I be using?

[Nate Chapin, 2015-09-03 21:02:06]

https://codereview.chromium.org/1302333003/diff/1/Source/web/tests/WebFrameTe...
File Source/web/tests/WebFrameTest.cpp (right):

https://codereview.chromium.org/1302333003/diff/1/Source/web/tests/WebFrameTe...
Source/web/tests/WebFrameTest.cpp:7093: StartLoad(mainFrame, m_baseURL +
"frame-a-b-c.html", &frameClient, &gotCommit);
What does this (and above) do that webViewHelper.initializeAndLoad() doesn't?

[sky, 2015-09-03 21:03:45]

https://codereview.chromium.org/1302333003/diff/1/Source/web/tests/WebFrameTe...
File Source/web/tests/WebFrameTest.cpp (right):

https://codereview.chromium.org/1302333003/diff/1/Source/web/tests/WebFrameTe...
Source/web/tests/WebFrameTest.cpp:7093: StartLoad(mainFrame, m_baseURL +
"frame-a-b-c.html", &frameClient, &gotCommit);
On 2015/09/03 21:02:06, Nate Chapin wrote:
> What does this (and above) do that webViewHelper.initializeAndLoad() doesn't?

It pumps events until didCommitProvisionalLoad is received, then it stops.

[Nate Chapin, 2015-09-03 21:52:38]

https://codereview.chromium.org/1302333003/diff/1/Source/web/tests/WebFrameTe...
File Source/web/tests/WebFrameTest.cpp (right):

https://codereview.chromium.org/1302333003/diff/1/Source/web/tests/WebFrameTe...
Source/web/tests/WebFrameTest.cpp:7093: StartLoad(mainFrame, m_baseURL +
"frame-a-b-c.html", &frameClient, &gotCommit);
On 2015/09/03 21:03:44, sky wrote:
> On 2015/09/03 21:02:06, Nate Chapin wrote:
> > What does this (and above) do that webViewHelper.initializeAndLoad()
doesn't?
> 
> It pumps events until didCommitProvisionalLoad is received, then it stops.

Instead of pumping manually, could you just do the WebRemoteFrame creation and
swap directly inside didCommitProvisionalLoad?

[sky, 2015-09-04 16:56:38]

Ok, I changed it around to do the swap when the title changes and that exercises
the bug. Take another look?

[Nate Chapin, 2015-09-04 18:30:47]

LGTM % nits

https://codereview.chromium.org/1302333003/diff/60001/Source/web/tests/WebFra...
File Source/web/tests/WebFrameTest.cpp (right):

https://codereview.chromium.org/1302333003/diff/60001/Source/web/tests/WebFra...
Source/web/tests/WebFrameTest.cpp:7032: void didReceiveTitle(WebLocalFrame*
frame, const WebString& title, WebTextDirection direction) override
Style nit: drop the unused variable names.

https://codereview.chromium.org/1302333003/diff/60001/Source/web/tests/WebFra...
Source/web/tests/WebFrameTest.cpp:7038: private:
Nit: remove this

[sky, 2015-09-04 18:57:04]

The CQ bit was checked by sky@chromium.org

[sky, 2015-09-04 18:57:04]

The patchset sent to the CQ was uploaded after l-g-t-m from japhet@chromium.org
Link to the patchset: https://codereview.chromium.org/1302333003/#ps80001
(title: "nits and merge")

[sky, 2015-09-04 18:57:14]

https://codereview.chromium.org/1302333003/diff/60001/Source/web/tests/WebFra...
File Source/web/tests/WebFrameTest.cpp (right):

https://codereview.chromium.org/1302333003/diff/60001/Source/web/tests/WebFra...
Source/web/tests/WebFrameTest.cpp:7032: void didReceiveTitle(WebLocalFrame*
frame, const WebString& title, WebTextDirection direction) override
On 2015/09/04 18:30:47, Nate Chapin wrote:
> Style nit: drop the unused variable names.

Done.

https://codereview.chromium.org/1302333003/diff/60001/Source/web/tests/WebFra...
Source/web/tests/WebFrameTest.cpp:7038: private:
On 2015/09/04 18:30:47, Nate Chapin wrote:
> Nit: remove this

Done.

[commit-bot: I haz the power, 2015-09-04 18:57:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1302333003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1302333003/80001

[commit-bot: I haz the power, 2015-09-04 19:58:02]

Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201818