Issue 130233002: Fix Feedback to use it's own profile in incognito/guest sessions and not redirect to the default pr…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 130233002: Fix Feedback to use it's own profile in incognito/guest sessions and not redirect to the default pr… (Closed)

Created:
6 years, 11 months ago by rkc

Modified:
6 years, 11 months ago

Reviewers:
xiyuan, asargent_no_longer_on_chrome

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org, Dmitry Polukhin

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fix Feedback to use it's own profile in incognito/guest sessions and not redirect to the default profile. Also requires the extension to be loaded in split mode for incognito. R=asargent@chromium.org, xiyuan@chromium.org BUG=331197 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243987

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/browser/extensions/api/feedback_private/feedback_private_api.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/resources/feedback/manifest.json	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/130233002/1

6 years, 11 months ago (2014-01-09 19:52:13 UTC) #4

Message was sent while issue was closed.

Change committed as 243987