Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1302323005: Devtools UI: Add shortcut for activating/deactivating breakpoints (Closed)

Created:
5 years, 3 months ago by samli
Modified:
5 years, 3 months ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, yurys+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Devtools UI: Add shortcut for activating/deactivating breakpoints This adds a Ctrl+F8 (Mac Cmd+F8) shortcut for toggling breakpoints functionality. BUG=525879 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201442

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -5 lines) Patch
M Source/devtools/front_end/main/Main.js View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sources/SourcesPanel.js View 3 chunks +5 lines, -4 lines 0 comments Download
M Source/devtools/front_end/sources/module.json View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
samli
5 years, 3 months ago (2015-08-28 22:45:31 UTC) #2
pfeldman
lgtm https://codereview.chromium.org/1302323005/diff/1/Source/devtools/front_end/sources/module.json File Source/devtools/front_end/sources/module.json (right): https://codereview.chromium.org/1302323005/diff/1/Source/devtools/front_end/sources/module.json#newcode137 Source/devtools/front_end/sources/module.json:137: "shortcut": "Ctrl+F8" This would also need to work ...
5 years, 3 months ago (2015-08-28 23:08:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1302323005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1302323005/1
5 years, 3 months ago (2015-08-28 23:27:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1302323005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1302323005/20001
5 years, 3 months ago (2015-08-28 23:39:54 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-08-29 01:19:11 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201442

Powered by Google App Engine
This is Rietveld 408576698