Remove year+ old migration support of "session.urls_to_restore_on_startup".

components/syncable_prefs/pref_service_syncable_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/syncable_prefs/pref_service_syncable.h"
 
 #include "base/json/json_reader.h"
 #include "base/json/json_string_value_serializer.h"
 #include "base/json/json_writer.h"
 #include "base/message_loop/message_loop.h"
@@ skipping 17 matching lines @@
 using syncer::SyncData;
 
 namespace syncable_prefs {
 
 namespace {
 
 const char kExampleUrl0[] = "http://example.com/0";
 const char kExampleUrl1[] = "http://example.com/1";
 const char kExampleUrl2[] = "http://example.com/2";
 const char kStringPrefName[] = "string_pref_name";
-const char kListPrefName[] = "new_list_pref_name";
-const char kListOldPrefName[] = "list_pref_name";
+const char kListPrefName[] = "list_pref_name";
 const char kUnsyncedPreferenceName[] = "nonsense_pref_name";
 const char kUnsyncedPreferenceDefaultValue[] = "default";
 const char kDefaultCharsetPrefName[] = "default_charset";
 const char kNonDefaultCharsetValue[] = "foo";
 const char kDefaultCharsetValue[] = "utf-8";
 
 class TestPrefModelAssociatorClient : public PrefModelAssociatorClient {
  public:
   TestPrefModelAssociatorClient() {}
   ~TestPrefModelAssociatorClient() override {}
 
   // PrefModelAssociatorClient implementation.
   bool IsMergeableListPreference(const std::string& pref_name) const override {
     return pref_name == kListPrefName;
   }
 
   bool IsMergeableDictionaryPreference(
       const std::string& pref_name) const override {
     return false;
   }
 
-  bool IsMigratedPreference(const std::string& new_pref_name,
-                            std::string* old_pref_name) const override {
-    if (new_pref_name != kListPrefName)
-      return false;
-    old_pref_name->assign(kListOldPrefName);
-    return true;
-  }
-
-  bool IsOldMigratedPreference(const std::string& old_pref_name,
-                               std::string* new_pref_name) const override {
-    if (old_pref_name != kListOldPrefName)
-      return false;
-    new_pref_name->assign(kListPrefName);
-    return true;
-  }
-
  private:
   DISALLOW_COPY_AND_ASSIGN(TestPrefModelAssociatorClient);
 };
 
 class TestSyncProcessorStub : public syncer::SyncChangeProcessor {
  public:
   explicit TestSyncProcessorStub(syncer::SyncChangeList* output)
       : output_(output), fail_next_(false) {}
   syncer::SyncError ProcessSyncChanges(
       const tracked_objects::Location& from_here,
@@ skipping 32 matching lines @@
     prefs_.SetPrefModelAssociatorClientForTesting(&client_);
     prefs_.registry()->RegisterStringPref(kUnsyncedPreferenceName,
                                           kUnsyncedPreferenceDefaultValue);
     prefs_.registry()->RegisterStringPref(
         kStringPrefName,
         std::string(),
         user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
     prefs_.registry()->RegisterListPref(
         kListPrefName,
         user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
-    prefs_.registry()->RegisterListPref(kListOldPrefName);
     prefs_.registry()->RegisterStringPref(
         kDefaultCharsetPrefName,
         kDefaultCharsetValue,
         user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
 
     pref_sync_service_ = reinterpret_cast<PrefModelAssociator*>(
         prefs_.GetSyncableService(syncer::PREFERENCES));
     ASSERT_TRUE(pref_sync_service_);
     next_pref_remote_sync_node_id_ = 0;
   }
@@ skipping 74 matching lines @@
   }
 
   bool IsSynced(const std::string& pref_name) {
     return pref_sync_service_->registered_preferences().count(pref_name) > 0;
   }
 
   bool HasSyncData(const std::string& pref_name) {
     return pref_sync_service_->IsPrefSynced(pref_name);
   }
 
-  // Returns whether a given preference name is a new name of a migrated
-  // preference. Exposed here for testing.
-  bool IsMigratedPreference(const char* preference_name) {
-    std::string old_pref_name;
-    return client_.IsMigratedPreference(preference_name, &old_pref_name);
-  }
-
-  bool IsOldMigratedPreference(const char* old_preference_name) {
-    std::string new_pref_name;
-    return client_.IsOldMigratedPreference(old_preference_name, &new_pref_name);
-  }
-
   PrefService* GetPrefs() { return &prefs_; }
   TestingPrefServiceSyncable* GetTestingPrefService() { return &prefs_; }
 
  protected:
   TestPrefModelAssociatorClient client_;
   TestingPrefServiceSyncable prefs_;
 
   PrefModelAssociator* pref_sync_service_;
   TestSyncProcessorStub* test_processor_;
 
@@ skipping 80 matching lines @@
   expected_urls->Append(new base::StringValue(kExampleUrl1));
   expected_urls->Append(new base::StringValue(kExampleUrl2));
   expected_urls->Append(new base::StringValue(kExampleUrl0));
   scoped_ptr<base::Value> value(FindValue(kListPrefName, out));
   ASSERT_TRUE(value.get());
   EXPECT_TRUE(value->Equals(expected_urls.get()));
   EXPECT_TRUE(GetPreferenceValue(kListPrefName).Equals(expected_urls.get()));
   EXPECT_EQ(kNonDefaultCharsetValue, prefs_.GetString(kDefaultCharsetPrefName));
 }
 
-TEST_F(PrefServiceSyncableTest, ModelAssociationMigrateOldData) {
-  ASSERT_TRUE(IsMigratedPreference(kListPrefName));
-  ASSERT_TRUE(IsOldMigratedPreference(kListOldPrefName));
-
-  syncer::SyncDataList in;
-  syncer::SyncChangeList out;
-  base::ListValue urls_to_restore;
-  urls_to_restore.Append(new base::StringValue(kExampleUrl1));
-  urls_to_restore.Append(new base::StringValue(kExampleUrl2));
-  AddToRemoteDataList(kListOldPrefName, urls_to_restore, &in);
-  InitWithSyncDataTakeOutput(in, &out);
-
-  // Expect that the new preference data contains the old pref's values.
-  scoped_ptr<base::ListValue> expected_urls(new base::ListValue);
-  expected_urls->Append(new base::StringValue(kExampleUrl1));
-  expected_urls->Append(new base::StringValue(kExampleUrl2));
-
-  ASSERT_TRUE(HasSyncData(kListPrefName));
-  scoped_ptr<base::Value> value(FindValue(kListPrefName, out));
-  ASSERT_TRUE(value.get());
-  EXPECT_TRUE(value->Equals(expected_urls.get()));
-  EXPECT_TRUE(GetPreferenceValue(kListPrefName).Equals(expected_urls.get()));
-
-  // The old preference value should be the same.
-  expected_urls.reset(new base::ListValue);
-  ASSERT_FALSE(FindValue(kListOldPrefName, out).get());
-  EXPECT_TRUE(GetPreferenceValue(kListOldPrefName).Equals(expected_urls.get()));
-}
-
-TEST_F(PrefServiceSyncableTest, ModelAssociationCloudHasOldMigratedData) {
-  ASSERT_TRUE(IsMigratedPreference(kListPrefName));
-  ASSERT_TRUE(IsOldMigratedPreference(kListOldPrefName));
-  prefs_.SetString(kStringPrefName, kExampleUrl0);
-  {
-    ListPrefUpdate update(GetPrefs(), kListPrefName);
-    base::ListValue* url_list = update.Get();
-    url_list->Append(new base::StringValue(kExampleUrl0));
-    url_list->Append(new base::StringValue(kExampleUrl1));
-  }
-
-  syncer::SyncDataList in;
-  syncer::SyncChangeList out;
-  base::ListValue urls_to_restore;
-  urls_to_restore.Append(new base::StringValue(kExampleUrl1));
-  urls_to_restore.Append(new base::StringValue(kExampleUrl2));
-  AddToRemoteDataList(kListOldPrefName, urls_to_restore, &in);
-  AddToRemoteDataList(kStringPrefName, base::StringValue(kExampleUrl1), &in);
-  InitWithSyncDataTakeOutput(in, &out);
-
-  ASSERT_FALSE(FindValue(kStringPrefName, out).get());
-
-  // Expect that the new preference data contains the merged old prefs values.
-  scoped_ptr<base::ListValue> expected_urls(new base::ListValue);
-  expected_urls->Append(new base::StringValue(kExampleUrl1));
-  expected_urls->Append(new base::StringValue(kExampleUrl2));
-  expected_urls->Append(new base::StringValue(kExampleUrl0));
-
-  ASSERT_TRUE(HasSyncData(kListPrefName));
-  scoped_ptr<base::Value> value(FindValue(kListPrefName, out));
-  ASSERT_TRUE(value.get());
-  EXPECT_TRUE(value->Equals(expected_urls.get()));
-  EXPECT_TRUE(GetPreferenceValue(kListPrefName).Equals(expected_urls.get()));
-
-  expected_urls.reset(new base::ListValue);
-  value = FindValue(kListOldPrefName, out).Pass();
-  ASSERT_TRUE(value.get());
-  EXPECT_TRUE(GetPreferenceValue(kListOldPrefName).Equals(expected_urls.get()));
-}
-
-TEST_F(PrefServiceSyncableTest, ModelAssociationCloudHasNewMigratedData) {
-  ASSERT_TRUE(IsMigratedPreference(kListPrefName));
-  ASSERT_TRUE(IsOldMigratedPreference(kListOldPrefName));
-  prefs_.SetString(kStringPrefName, kExampleUrl0);
-  {
-    ListPrefUpdate update(GetPrefs(), kListOldPrefName);
-    base::ListValue* url_list = update.Get();
-    url_list->Append(new base::StringValue(kExampleUrl0));
-    url_list->Append(new base::StringValue(kExampleUrl1));
-  }
-
-  syncer::SyncDataList in;
-  syncer::SyncChangeList out;
-  base::ListValue urls_to_restore;
-  urls_to_restore.Append(new base::StringValue(kExampleUrl1));
-  urls_to_restore.Append(new base::StringValue(kExampleUrl2));
-  AddToRemoteDataList(kListOldPrefName, urls_to_restore, &in);
-  AddToRemoteDataList(kStringPrefName, base::StringValue(kExampleUrl1), &in);
-  InitWithSyncDataTakeOutput(in, &out);
-
-  scoped_ptr<base::Value> value(FindValue(kStringPrefName, out));
-  ASSERT_FALSE(value.get());
-
-  // Expect that the cloud data under the new migrated preference name sticks.
-  scoped_ptr<base::ListValue> expected_urls(new base::ListValue);
-  expected_urls->Append(new base::StringValue(kExampleUrl1));
-  expected_urls->Append(new base::StringValue(kExampleUrl2));
-
-  ASSERT_TRUE(HasSyncData(kListPrefName));
-  value = FindValue(kListPrefName, out).Pass();
-  ASSERT_TRUE(value.get());
-  EXPECT_TRUE(value->Equals(expected_urls.get()));
-  EXPECT_TRUE(GetPreferenceValue(kListPrefName).Equals(expected_urls.get()));
-
-  // The old preference data should still be here, though not synced.
-  expected_urls.reset(new base::ListValue);
-  expected_urls->Append(new base::StringValue(kExampleUrl0));
-  expected_urls->Append(new base::StringValue(kExampleUrl1));
-
-  value = FindValue(kListOldPrefName, out).Pass();
-  ASSERT_FALSE(value.get());
-  EXPECT_TRUE(GetPreferenceValue(kListOldPrefName).Equals(expected_urls.get()));
-}
-
-TEST_F(PrefServiceSyncableTest,
-       ModelAssociationCloudAddsOldAndNewMigratedData) {
-  ASSERT_TRUE(IsMigratedPreference(kListPrefName));
-  ASSERT_TRUE(IsOldMigratedPreference(kListOldPrefName));
-  prefs_.SetString(kStringPrefName, kExampleUrl0);
-  {
-    ListPrefUpdate update_old(GetPrefs(), kListOldPrefName);
-    base::ListValue* url_list_old = update_old.Get();
-    url_list_old->Append(new base::StringValue(kExampleUrl0));
-    url_list_old->Append(new base::StringValue(kExampleUrl1));
-    ListPrefUpdate update(GetPrefs(), kListPrefName);
-    base::ListValue* url_list = update.Get();
-    url_list->Append(new base::StringValue(kExampleUrl1));
-    url_list->Append(new base::StringValue(kExampleUrl2));
-  }
-
-  syncer::SyncDataList in;
-  syncer::SyncChangeList out;
-  AddToRemoteDataList(kStringPrefName, base::StringValue(kExampleUrl1), &in);
-  InitWithSyncDataTakeOutput(in, &out);
-
-  scoped_ptr<base::Value> value(FindValue(kStringPrefName, out));
-  ASSERT_FALSE(value.get());
-
-  // Expect that the cloud data under the new migrated preference name sticks.
-  scoped_ptr<base::ListValue> expected_urls(new base::ListValue);
-  expected_urls->Append(new base::StringValue(kExampleUrl1));
-  expected_urls->Append(new base::StringValue(kExampleUrl2));
-
-  ASSERT_TRUE(HasSyncData(kListPrefName));
-  value = FindValue(kListPrefName, out).Pass();
-  ASSERT_TRUE(value.get());
-  EXPECT_TRUE(value->Equals(expected_urls.get()));
-  EXPECT_TRUE(GetPreferenceValue(kListPrefName).Equals(expected_urls.get()));
-
-  // Should not have synced in the old startup url values.
-  value = FindValue(kListOldPrefName, out).Pass();
-  ASSERT_FALSE(value.get());
-  EXPECT_FALSE(
-      GetPreferenceValue(kListOldPrefName).Equals(expected_urls.get()));
-}
-
 TEST_F(PrefServiceSyncableTest, FailModelAssociation) {
   syncer::SyncChangeList output;
   TestSyncProcessorStub* stub = new TestSyncProcessorStub(&output);
   stub->FailNextProcessSyncChanges();
   syncer::SyncMergeResult r = pref_sync_service_->MergeDataAndStartSyncing(
       syncer::PREFERENCES, syncer::SyncDataList(),
       scoped_ptr<syncer::SyncChangeProcessor>(stub),
       scoped_ptr<syncer::SyncErrorFactory>(
           new syncer::SyncErrorFactoryMock()));
   EXPECT_TRUE(r.error().IsSet());
@@ skipping 235 matching lines @@
   syncer::SyncChangeList list;
   list.push_back(MakeRemoteChange(
       1, kStringPrefName, *null_value, SyncChange::ACTION_DELETE));
   pref_sync_service_->ProcessSyncChanges(FROM_HERE, list);
   EXPECT_TRUE(pref->IsDefaultValue());
 }
 
 }  // namespace
 
 }  // namespace syncable_prefs