Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 13023002: Change chrome.filesystem to handle the Chrome OS Drive file entries directly. (Closed)

Created:
7 years, 9 months ago by kinaba
Modified:
7 years, 9 months ago
Reviewers:
benwells
CC:
chromium-reviews, tzik+watch_chromium.org, Aaron Boodman, kinuko+watch, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Change chrome.filesystem to handle the Chrome OS Drive file entries directly. This CL shows the Drive folder in the open file dialog, and allows the app to select the real entry of the remote file, rather than its local cache. BUG=156277 TEST=Run the sample text editor chrome app, and open a Drive file via the open-file dialog on Chrome OS. Should see "/special/drive/..." path. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190394

Patch Set 1 #

Patch Set 2 : Test fix (+rebase). #

Patch Set 3 : More test fix. #

Total comments: 2

Patch Set 4 : COmment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -4 lines) Patch
M apps/app_restore_service_browsertest.cc View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/file_handlers/app_file_handler_util.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_api.h View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_api.cc View 1 2 5 chunks +36 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_apitest.cc View 1 2 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
kinaba
Please take a look, thanks. This should be landed on top of https://codereview.chromium.org/12717014/. I'll send ...
7 years, 9 months ago (2013-03-22 08:32:41 UTC) #1
benwells
lgtm Can you add a TODO about write support if you don't get to it ...
7 years, 9 months ago (2013-03-24 05:16:54 UTC) #2
benwells
On 2013/03/24 05:16:54, benwells wrote: > lgtm > > Can you add a TODO about ...
7 years, 9 months ago (2013-03-24 05:17:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/13023002/1
7 years, 9 months ago (2013-03-24 22:39:18 UTC) #4
kinaba
On 2013/03/24 22:39:18, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
7 years, 9 months ago (2013-03-25 00:14:49 UTC) #5
kinaba
Fixed the tests. Ben, would you mind taking another look at Patch Set 3? I'm ...
7 years, 9 months ago (2013-03-25 04:19:43 UTC) #6
benwells
lgtm with comment added. https://codereview.chromium.org/13023002/diff/23001/chrome/browser/extensions/api/file_system/file_system_api.h File chrome/browser/extensions/api/file_system/file_system_api.h (right): https://codereview.chromium.org/13023002/diff/23001/chrome/browser/extensions/api/file_system/file_system_api.h#newcode76 chrome/browser/extensions/api/file_system/file_system_api.h:76: static void RegisterTempExternalFileSystemForTest(const std::string& name, ...
7 years, 9 months ago (2013-03-25 10:08:13 UTC) #7
kinaba
https://codereview.chromium.org/13023002/diff/23001/chrome/browser/extensions/api/file_system/file_system_api.h File chrome/browser/extensions/api/file_system/file_system_api.h (right): https://codereview.chromium.org/13023002/diff/23001/chrome/browser/extensions/api/file_system/file_system_api.h#newcode76 chrome/browser/extensions/api/file_system/file_system_api.h:76: static void RegisterTempExternalFileSystemForTest(const std::string& name, On 2013/03/25 10:08:13, benwells ...
7 years, 9 months ago (2013-03-25 12:07:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/13023002/37001
7 years, 9 months ago (2013-03-25 12:08:37 UTC) #9
commit-bot: I haz the power
7 years, 9 months ago (2013-03-25 14:15:55 UTC) #10
Message was sent while issue was closed.
Change committed as 190394

Powered by Google App Engine
This is Rietveld 408576698