Issue 1302283002: Make LineSplitter.split return an Iterable<String>, not Iterable<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1302283002: Make LineSplitter.split return an Iterable<String>, not Iterable<>.

Created:
5 years, 4 months ago by Lasse Reichstein Nielsen

Modified:
4 years, 9 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Make LineSplitter.split return an Iterable<String>, not Iterable<>.

Patch Set 1 #

Total comments: 1

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -19 lines)			Patch
	M	sdk/lib/convert/line_splitter.dart	View		2 chunks	+50 lines, -19 lines	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Lasse Reichstein Nielsen

That's what returning an Iterable<String> would be. Alternatively we could just use a delegating iterable ...

5 years, 4 months ago (2015-08-21 09:18:44 UTC) #2

floitsch

LGTM, but I leave it up to you. It's a trade-off: it looks less worse, ...

5 years, 4 months ago (2015-08-21 09:23:12 UTC) #3

floitsch

4 years, 9 months ago (2016-03-08 12:35:34 UTC) #4

https://codereview.chromium.org/1302283002/diff/1/sdk/lib/convert/line_splitt...
File sdk/lib/convert/line_splitter.dart (right):

https://codereview.chromium.org/1302283002/diff/1/sdk/lib/convert/line_splitt...
sdk/lib/convert/line_splitter.dart:74: // Break on CR or CR+LF
Finish with "."

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages