Issue 1302273005: Minor clean-up to getValueName (i.e. CSSValueID -> string conversion)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1302273005: Minor clean-up to getValueName (i.e. CSSValueID -> string conversion) (Closed)

Created:
5 years, 3 months ago by Timothy Loh

Modified:
5 years, 3 months ago

Reviewers:
sashab, alancutter (OOO until 2018)

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Minor clean-up to getValueName (i.e. CSSValueID -> string conversion) This patch makes a few small clean-ups to getValueName: - Type argument as CSSValueID instead of unsigned short - Disallow trying to serialize invalid CSSValueIDs - Don't add values for CSSValueInvalid in the offset tables Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201283

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -8 lines)			Patch
	M	Source/build/scripts/make_css_value_keywords.py	View		4 chunks	+6 lines, -8 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1302273005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1302273005/1

5 years, 3 months ago (2015-08-27 02:51:59 UTC) #5

commit-bot: I haz the power

5 years, 3 months ago (2015-08-27 03:29:35 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201283

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages