Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Issue 1302273002: [heap] Thread through GC flags in memory reducer and incremental marking. (Closed)

Created:
5 years, 4 months ago by Michael Lippautz
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Thread through GC flags in memory reducer and incremental marking. BUG=chromium:520607 LOG=N Committed: https://crrev.com/7a21a70c4ea61251b9875991b8b4fd4f4eddef34 Cr-Commit-Position: refs/heads/master@{#30287}

Patch Set 1 #

Patch Set 2 : remove leftover from patching #

Total comments: 1

Patch Set 3 : Addressed comment #

Patch Set 4 : Fix scavenger call in test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M src/heap/heap.cc View 1 2 4 chunks +11 lines, -6 lines 0 comments Download
M test/cctest/test-heap.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
Michael Lippautz
5 years, 4 months ago (2015-08-21 08:20:51 UTC) #2
Hannes Payer (out of office)
lgtm, with one comment https://codereview.chromium.org/1302273002/diff/20001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1302273002/diff/20001/src/heap/heap.cc#newcode743 src/heap/heap.cc:743: CollectAllGarbage(Heap::kNoGCFlags, "GC interrupt", Pass current ...
5 years, 4 months ago (2015-08-21 08:46:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1302273002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1302273002/40001
5 years, 4 months ago (2015-08-21 08:50:53 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/8904)
5 years, 4 months ago (2015-08-21 08:59:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1302273002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1302273002/60001
5 years, 4 months ago (2015-08-21 09:40:28 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 4 months ago (2015-08-21 10:05:23 UTC) #12
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 10:05:43 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/7a21a70c4ea61251b9875991b8b4fd4f4eddef34
Cr-Commit-Position: refs/heads/master@{#30287}

Powered by Google App Engine
This is Rietveld 408576698