ui/views/view.cc - Issue 1302233006: aura: Stop converting Rect to RectF implicitly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/view.cc

Issue 1302233006: aura: Stop converting Rect to RectF implicitly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rectfconvert-aura: . Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/view.cc

diff --git a/ui/views/view.cc b/ui/views/view.cc

index 3c2aed7dbab63c64d06b4554d32574d33b66d92f..7e0440ea729e188ef97ac865d10b6368ce08dfa5 100644

--- a/ui/views/view.cc

+++ b/ui/views/view.cc

@@ -699,7 +699,7 @@ void View::ConvertPointFromScreen(const View* dst, gfx::Point* p) {

}

gfx::Rect View::ConvertRectToParent(const gfx::Rect& rect) const {

- gfx::RectF x_rect = rect;

+ gfx::RectF x_rect = gfx::RectF(rect);

GetTransform().TransformRect(&x_rect);

x_rect.Offset(GetMirroredPosition().OffsetFromOrigin());

// Pixels we partially occupy in the parent should be included.