chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc - Issue 1302233006: aura: Stop converting Rect to RectF implicitly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

Issue 1302233006: aura: Stop converting Rect to RectF implicitly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rectfconvert-aura: . Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

index 348e085169026ebf6f3a03a35b1ee761f86606ac..9553ad55f97d8bd8bf0e8aa38507381a3d4b30cd 100644

--- a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

@@ -1212,13 +1212,10 @@ void AutofillDialogControllerImpl::UserEditedOrActivatedInput(

}

popup_controller_ = AutofillPopupControllerImpl::GetOrCreate(

- popup_controller_,

- weak_ptr_factory_.GetWeakPtr(),

- NULL,

- parent_view,

- content_bounds,

- base::i18n::IsRTL() ?

- base::i18n::RIGHT_TO_LEFT : base::i18n::LEFT_TO_RIGHT);

+ popup_controller_, weak_ptr_factory_.GetWeakPtr(), NULL, parent_view,

+ gfx::RectF(content_bounds),

+ base::i18n::IsRTL() ? base::i18n::RIGHT_TO_LEFT

+ : base::i18n::LEFT_TO_RIGHT);

popup_controller_->Show(popup_suggestions);

}