Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Side by Side Diff: base/nix/xdg_util_unittest.cc

Issue 1302233003: Replace gmock's deprecated SetArgumentPointee with SetArgPointee. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: 2017 Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/nix/xdg_util.h" 5 #include "base/nix/xdg_util.h"
6 6
7 #include "base/environment.h" 7 #include "base/environment.h"
8 #include "testing/gmock/include/gmock/gmock.h" 8 #include "testing/gmock/include/gmock/gmock.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
11 using ::testing::_; 11 using ::testing::_;
12 using ::testing::Eq; 12 using ::testing::Eq;
13 using ::testing::Return; 13 using ::testing::Return;
14 using ::testing::SetArgumentPointee; 14 using ::testing::SetArgPointee;
15 15
16 namespace base { 16 namespace base {
17 namespace nix { 17 namespace nix {
18 18
19 namespace { 19 namespace {
20 20
21 class MockEnvironment : public Environment { 21 class MockEnvironment : public Environment {
22 public: 22 public:
23 MOCK_METHOD2(GetVar, bool(StringPiece, std::string* result)); 23 MOCK_METHOD2(GetVar, bool(StringPiece, std::string* result));
24 MOCK_METHOD2(SetVar, bool(StringPiece, const std::string& new_value)); 24 MOCK_METHOD2(SetVar, bool(StringPiece, const std::string& new_value));
(...skipping 17 matching lines...) Expand all
42 const char kDesktopSession[] = "DESKTOP_SESSION"; 42 const char kDesktopSession[] = "DESKTOP_SESSION";
43 const char kKDESession[] = "KDE_SESSION_VERSION"; 43 const char kKDESession[] = "KDE_SESSION_VERSION";
44 const char kXdgDesktop[] = "XDG_CURRENT_DESKTOP"; 44 const char kXdgDesktop[] = "XDG_CURRENT_DESKTOP";
45 45
46 } // namespace 46 } // namespace
47 47
48 TEST(XDGUtilTest, GetDesktopEnvironmentGnome) { 48 TEST(XDGUtilTest, GetDesktopEnvironmentGnome) {
49 MockEnvironment getter; 49 MockEnvironment getter;
50 EXPECT_CALL(getter, GetVar(_, _)).WillRepeatedly(Return(false)); 50 EXPECT_CALL(getter, GetVar(_, _)).WillRepeatedly(Return(false));
51 EXPECT_CALL(getter, GetVar(Eq(kDesktopSession), _)) 51 EXPECT_CALL(getter, GetVar(Eq(kDesktopSession), _))
52 .WillOnce(DoAll(SetArgumentPointee<1>(kDesktopGnome), Return(true))); 52 .WillOnce(DoAll(SetArgPointee<1>(kDesktopGnome), Return(true)));
53 53
54 EXPECT_EQ(DESKTOP_ENVIRONMENT_GNOME, GetDesktopEnvironment(&getter)); 54 EXPECT_EQ(DESKTOP_ENVIRONMENT_GNOME, GetDesktopEnvironment(&getter));
55 } 55 }
56 56
57 TEST(XDGUtilTest, GetDesktopEnvironmentMATE) { 57 TEST(XDGUtilTest, GetDesktopEnvironmentMATE) {
58 MockEnvironment getter; 58 MockEnvironment getter;
59 EXPECT_CALL(getter, GetVar(_, _)).WillRepeatedly(Return(false)); 59 EXPECT_CALL(getter, GetVar(_, _)).WillRepeatedly(Return(false));
60 EXPECT_CALL(getter, GetVar(Eq(kDesktopSession), _)) 60 EXPECT_CALL(getter, GetVar(Eq(kDesktopSession), _))
61 .WillOnce(DoAll(SetArgumentPointee<1>(kDesktopMATE), Return(true))); 61 .WillOnce(DoAll(SetArgPointee<1>(kDesktopMATE), Return(true)));
62 62
63 EXPECT_EQ(DESKTOP_ENVIRONMENT_GNOME, GetDesktopEnvironment(&getter)); 63 EXPECT_EQ(DESKTOP_ENVIRONMENT_GNOME, GetDesktopEnvironment(&getter));
64 } 64 }
65 65
66 TEST(XDGUtilTest, GetDesktopEnvironmentKDE4) { 66 TEST(XDGUtilTest, GetDesktopEnvironmentKDE4) {
67 MockEnvironment getter; 67 MockEnvironment getter;
68 EXPECT_CALL(getter, GetVar(_, _)).WillRepeatedly(Return(false)); 68 EXPECT_CALL(getter, GetVar(_, _)).WillRepeatedly(Return(false));
69 EXPECT_CALL(getter, GetVar(Eq(kDesktopSession), _)) 69 EXPECT_CALL(getter, GetVar(Eq(kDesktopSession), _))
70 .WillOnce(DoAll(SetArgumentPointee<1>(kDesktopKDE4), Return(true))); 70 .WillOnce(DoAll(SetArgPointee<1>(kDesktopKDE4), Return(true)));
71 71
72 EXPECT_EQ(DESKTOP_ENVIRONMENT_KDE4, GetDesktopEnvironment(&getter)); 72 EXPECT_EQ(DESKTOP_ENVIRONMENT_KDE4, GetDesktopEnvironment(&getter));
73 } 73 }
74 74
75 TEST(XDGUtilTest, GetDesktopEnvironmentKDE3) { 75 TEST(XDGUtilTest, GetDesktopEnvironmentKDE3) {
76 MockEnvironment getter; 76 MockEnvironment getter;
77 EXPECT_CALL(getter, GetVar(_, _)).WillRepeatedly(Return(false)); 77 EXPECT_CALL(getter, GetVar(_, _)).WillRepeatedly(Return(false));
78 EXPECT_CALL(getter, GetVar(Eq(kDesktopSession), _)) 78 EXPECT_CALL(getter, GetVar(Eq(kDesktopSession), _))
79 .WillOnce(DoAll(SetArgumentPointee<1>(kDesktopKDE), Return(true))); 79 .WillOnce(DoAll(SetArgPointee<1>(kDesktopKDE), Return(true)));
80 80
81 EXPECT_EQ(DESKTOP_ENVIRONMENT_KDE3, GetDesktopEnvironment(&getter)); 81 EXPECT_EQ(DESKTOP_ENVIRONMENT_KDE3, GetDesktopEnvironment(&getter));
82 } 82 }
83 83
84 TEST(XDGUtilTest, GetDesktopEnvironmentXFCE) { 84 TEST(XDGUtilTest, GetDesktopEnvironmentXFCE) {
85 MockEnvironment getter; 85 MockEnvironment getter;
86 EXPECT_CALL(getter, GetVar(_, _)).WillRepeatedly(Return(false)); 86 EXPECT_CALL(getter, GetVar(_, _)).WillRepeatedly(Return(false));
87 EXPECT_CALL(getter, GetVar(Eq(kDesktopSession), _)) 87 EXPECT_CALL(getter, GetVar(Eq(kDesktopSession), _))
88 .WillOnce(DoAll(SetArgumentPointee<1>(kDesktopXFCE), Return(true))); 88 .WillOnce(DoAll(SetArgPointee<1>(kDesktopXFCE), Return(true)));
89 89
90 EXPECT_EQ(DESKTOP_ENVIRONMENT_XFCE, GetDesktopEnvironment(&getter)); 90 EXPECT_EQ(DESKTOP_ENVIRONMENT_XFCE, GetDesktopEnvironment(&getter));
91 } 91 }
92 92
93 TEST(XDGUtilTest, GetXdgDesktopGnome) { 93 TEST(XDGUtilTest, GetXdgDesktopGnome) {
94 MockEnvironment getter; 94 MockEnvironment getter;
95 EXPECT_CALL(getter, GetVar(_, _)).WillRepeatedly(Return(false)); 95 EXPECT_CALL(getter, GetVar(_, _)).WillRepeatedly(Return(false));
96 EXPECT_CALL(getter, GetVar(Eq(kXdgDesktop), _)) 96 EXPECT_CALL(getter, GetVar(Eq(kXdgDesktop), _))
97 .WillOnce(DoAll(SetArgumentPointee<1>(kXdgDesktopGNOME), Return(true))); 97 .WillOnce(DoAll(SetArgPointee<1>(kXdgDesktopGNOME), Return(true)));
98 98
99 EXPECT_EQ(DESKTOP_ENVIRONMENT_GNOME, GetDesktopEnvironment(&getter)); 99 EXPECT_EQ(DESKTOP_ENVIRONMENT_GNOME, GetDesktopEnvironment(&getter));
100 } 100 }
101 101
102 TEST(XDGUtilTest, GetXdgDesktopGnomeFallback) { 102 TEST(XDGUtilTest, GetXdgDesktopGnomeFallback) {
103 MockEnvironment getter; 103 MockEnvironment getter;
104 EXPECT_CALL(getter, GetVar(_, _)).WillRepeatedly(Return(false)); 104 EXPECT_CALL(getter, GetVar(_, _)).WillRepeatedly(Return(false));
105 EXPECT_CALL(getter, GetVar(Eq(kXdgDesktop), _)) 105 EXPECT_CALL(getter, GetVar(Eq(kXdgDesktop), _))
106 .WillOnce(DoAll(SetArgumentPointee<1>(kXdgDesktopUnity), Return(true))); 106 .WillOnce(DoAll(SetArgPointee<1>(kXdgDesktopUnity), Return(true)));
107 EXPECT_CALL(getter, GetVar(Eq(kDesktopSession), _)) 107 EXPECT_CALL(getter, GetVar(Eq(kDesktopSession), _))
108 .WillOnce( 108 .WillOnce(DoAll(SetArgPointee<1>(kDesktopGnomeFallback), Return(true)));
109 DoAll(SetArgumentPointee<1>(kDesktopGnomeFallback), Return(true)));
110 109
111 EXPECT_EQ(DESKTOP_ENVIRONMENT_GNOME, GetDesktopEnvironment(&getter)); 110 EXPECT_EQ(DESKTOP_ENVIRONMENT_GNOME, GetDesktopEnvironment(&getter));
112 } 111 }
113 112
114 TEST(XDGUtilTest, GetXdgDesktopKDE5) { 113 TEST(XDGUtilTest, GetXdgDesktopKDE5) {
115 MockEnvironment getter; 114 MockEnvironment getter;
116 EXPECT_CALL(getter, GetVar(_, _)).WillRepeatedly(Return(false)); 115 EXPECT_CALL(getter, GetVar(_, _)).WillRepeatedly(Return(false));
117 EXPECT_CALL(getter, GetVar(Eq(kXdgDesktop), _)) 116 EXPECT_CALL(getter, GetVar(Eq(kXdgDesktop), _))
118 .WillOnce(DoAll(SetArgumentPointee<1>(kXdgDesktopKDE), Return(true))); 117 .WillOnce(DoAll(SetArgPointee<1>(kXdgDesktopKDE), Return(true)));
119 EXPECT_CALL(getter, GetVar(Eq(kKDESession), _)) 118 EXPECT_CALL(getter, GetVar(Eq(kKDESession), _))
120 .WillOnce(DoAll(SetArgumentPointee<1>(kKDESessionKDE5), Return(true))); 119 .WillOnce(DoAll(SetArgPointee<1>(kKDESessionKDE5), Return(true)));
121 120
122 EXPECT_EQ(DESKTOP_ENVIRONMENT_KDE5, GetDesktopEnvironment(&getter)); 121 EXPECT_EQ(DESKTOP_ENVIRONMENT_KDE5, GetDesktopEnvironment(&getter));
123 } 122 }
124 123
125 TEST(XDGUtilTest, GetXdgDesktopKDE4) { 124 TEST(XDGUtilTest, GetXdgDesktopKDE4) {
126 MockEnvironment getter; 125 MockEnvironment getter;
127 EXPECT_CALL(getter, GetVar(_, _)).WillRepeatedly(Return(false)); 126 EXPECT_CALL(getter, GetVar(_, _)).WillRepeatedly(Return(false));
128 EXPECT_CALL(getter, GetVar(Eq(kXdgDesktop), _)) 127 EXPECT_CALL(getter, GetVar(Eq(kXdgDesktop), _))
129 .WillOnce(DoAll(SetArgumentPointee<1>(kXdgDesktopKDE), Return(true))); 128 .WillOnce(DoAll(SetArgPointee<1>(kXdgDesktopKDE), Return(true)));
130 129
131 EXPECT_EQ(DESKTOP_ENVIRONMENT_KDE4, GetDesktopEnvironment(&getter)); 130 EXPECT_EQ(DESKTOP_ENVIRONMENT_KDE4, GetDesktopEnvironment(&getter));
132 } 131 }
133 132
134 TEST(XDGUtilTest, GetXdgDesktopUnity) { 133 TEST(XDGUtilTest, GetXdgDesktopUnity) {
135 MockEnvironment getter; 134 MockEnvironment getter;
136 EXPECT_CALL(getter, GetVar(_, _)).WillRepeatedly(Return(false)); 135 EXPECT_CALL(getter, GetVar(_, _)).WillRepeatedly(Return(false));
137 EXPECT_CALL(getter, GetVar(Eq(kXdgDesktop), _)) 136 EXPECT_CALL(getter, GetVar(Eq(kXdgDesktop), _))
138 .WillOnce(DoAll(SetArgumentPointee<1>(kXdgDesktopUnity), Return(true))); 137 .WillOnce(DoAll(SetArgPointee<1>(kXdgDesktopUnity), Return(true)));
139 138
140 EXPECT_EQ(DESKTOP_ENVIRONMENT_UNITY, GetDesktopEnvironment(&getter)); 139 EXPECT_EQ(DESKTOP_ENVIRONMENT_UNITY, GetDesktopEnvironment(&getter));
141 } 140 }
142 141
143 TEST(XDGUtilTest, GetXdgDesktopUnity7) { 142 TEST(XDGUtilTest, GetXdgDesktopUnity7) {
144 MockEnvironment getter; 143 MockEnvironment getter;
145 EXPECT_CALL(getter, GetVar(_, _)).WillRepeatedly(Return(false)); 144 EXPECT_CALL(getter, GetVar(_, _)).WillRepeatedly(Return(false));
146 EXPECT_CALL(getter, GetVar(Eq(kXdgDesktop), _)) 145 EXPECT_CALL(getter, GetVar(Eq(kXdgDesktop), _))
147 .WillOnce(DoAll(SetArgumentPointee<1>(kXdgDesktopUnity7), Return(true))); 146 .WillOnce(DoAll(SetArgPointee<1>(kXdgDesktopUnity7), Return(true)));
148 147
149 EXPECT_EQ(DESKTOP_ENVIRONMENT_UNITY, GetDesktopEnvironment(&getter)); 148 EXPECT_EQ(DESKTOP_ENVIRONMENT_UNITY, GetDesktopEnvironment(&getter));
150 } 149 }
151 150
152 TEST(XDGUtilTest, GetXdgDesktopUnity8) { 151 TEST(XDGUtilTest, GetXdgDesktopUnity8) {
153 MockEnvironment getter; 152 MockEnvironment getter;
154 EXPECT_CALL(getter, GetVar(_, _)).WillRepeatedly(Return(false)); 153 EXPECT_CALL(getter, GetVar(_, _)).WillRepeatedly(Return(false));
155 EXPECT_CALL(getter, GetVar(Eq(kXdgDesktop), _)) 154 EXPECT_CALL(getter, GetVar(Eq(kXdgDesktop), _))
156 .WillOnce(DoAll(SetArgumentPointee<1>(kXdgDesktopUnity8), Return(true))); 155 .WillOnce(DoAll(SetArgPointee<1>(kXdgDesktopUnity8), Return(true)));
157 156
158 EXPECT_EQ(DESKTOP_ENVIRONMENT_UNITY, GetDesktopEnvironment(&getter)); 157 EXPECT_EQ(DESKTOP_ENVIRONMENT_UNITY, GetDesktopEnvironment(&getter));
159 } 158 }
160 159
161 } // namespace nix 160 } // namespace nix
162 } // namespace base 161 } // namespace base
OLDNEW
« no previous file with comments | « base/gmock_unittest.cc ('k') | chrome/browser/chromeos/attestation/platform_verification_flow_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698