Oilpan: Add a compile-time flag: DETAILED_MEMORY_INFRA

Oilpan: Add a compile-time flag: DETAILED_MEMORY_INFRA

All the memory stats should be displayed in memory-infra.
However, some memory stats are too heavy to profile in production builds.
We can use the DETAILED_MEMORY_INFRA flag for them.

BTW, GC_PROFILING flag will be removed soon. All the information in the GC profiler
has been migrated to memory-infra.

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201891

[haraken, 2015-09-08 01:08:18]

haraken@chromium.org changed reviewers:
+ bashi@chromium.org, hajimehoshi@chromium.org, keishi@chromium.org

[haraken, 2015-09-08 01:08:19]

PTAL

In this CL, the DETAILED_MEMORY_INFRA flag is used only for Oilpan. In the
future, the flag will be used for PartitionAlloc to dump per-object-type stats
etc.

[keishi, 2015-09-08 03:39:52]

LGTM

[bashi, 2015-09-08 03:52:28]

LGTM

https://codereview.chromium.org/1302183010/diff/1/Source/build/features.gypi
File Source/build/features.gypi (right):

https://codereview.chromium.org/1302183010/diff/1/Source/build/features.gypi#...
Source/build/features.gypi:54: 'blink_gc_profiling%': 0,
why can't we remove this now?

[haraken, 2015-09-08 04:00:43]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2015-09-08 04:00:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1302183010/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1302183010/1

[haraken, 2015-09-08 04:04:31]

> https://codereview.chromium.org/1302183010/diff/1/Source/build/features.gypi
> File Source/build/features.gypi (right):
> 
>
https://codereview.chromium.org/1302183010/diff/1/Source/build/features.gypi#...
> Source/build/features.gypi:54: 'blink_gc_profiling%': 0,
> why can't we remove this now?

We can. I just don't want to remove the profiler until we ship oilpan and
stabilize.

[commit-bot: I haz the power, 2015-09-08 04:54:07]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201891

[sof, 2015-09-08 06:13:38]

On 2015/09/08 04:04:31, haraken wrote:
> > https://codereview.chromium.org/1302183010/diff/1/Source/build/features.gypi
> > File Source/build/features.gypi (right):
> > 
> >
>
https://codereview.chromium.org/1302183010/diff/1/Source/build/features.gypi#...
> > Source/build/features.gypi:54: 'blink_gc_profiling%': 0,
> > why can't we remove this now?
> 
> We can. I just don't want to remove the profiler until we ship oilpan and
> stabilize.

Shouldn't the provision of GCInfo::className() be

  #if ENABLE(DETAILED_MEMORY_INFRA) || ENABLE(GC_PROFILING)

until then?

[haraken, 2015-09-08 06:22:15]

On 2015/09/08 06:13:38, sof wrote:
> On 2015/09/08 04:04:31, haraken wrote:
> > >
https://codereview.chromium.org/1302183010/diff/1/Source/build/features.gypi
> > > File Source/build/features.gypi (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/1302183010/diff/1/Source/build/features.gypi#...
> > > Source/build/features.gypi:54: 'blink_gc_profiling%': 0,
> > > why can't we remove this now?
> > 
> > We can. I just don't want to remove the profiler until we ship oilpan and
> > stabilize.
> 
> Shouldn't the provision of GCInfo::className() be
> 
>   #if ENABLE(DETAILED_MEMORY_INFRA) || ENABLE(GC_PROFILING)
> 
> until then?

Right, will fix.