Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1302173002: [M45] SkPaintFilterCanvas should inherit the target canvas state (Closed)

Created:
5 years, 4 months ago by f(malita)
Modified:
5 years, 4 months ago
Reviewers:
robertphillips, reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@m45
Target Ref:
refs/heads/chrome/m45
Project:
skia
Visibility:
Public.

Description

[M45] SkPaintFilterCanvas should inherit the target canvas state Cherry-pick of http://crrev.com/1294013002 for M45. Currently, SkPaintFilterCanvas does not provide any help in cloning target canvas state. While that could be handled in subclasses, it is easy to miss (see linked bug). This CL adds a new constructor variant which ensures that the initial matrix and clip bounds are inherited from the target canvas. BUG=516790 TBR=reed@google.com,robertphillips@google.com NOTREECHECKS=true NOTRY=true NOPRESUBMIT=true Committed: https://skia.googlesource.com/skia/+/7dcc609c3adb8077583b8b70dece697eeae5c574

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -0 lines) Patch
M include/utils/SkPaintFilterCanvas.h View 1 chunk +9 lines, -0 lines 0 comments Download
M src/utils/SkPaintFilterCanvas.cpp View 1 chunk +12 lines, -0 lines 0 comments Download
M tests/CanvasTest.cpp View 2 chunks +36 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1302173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1302173002/1
5 years, 4 months ago (2015-08-20 22:22:25 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 4 months ago (2015-08-20 22:22:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1302173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1302173002/1
5 years, 4 months ago (2015-08-20 22:28:53 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 22:29:02 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7dcc609c3adb8077583b8b70dece697eeae5c574

Powered by Google App Engine
This is Rietveld 408576698