Add autofill preview support for <month> input fields

Add autofill preview support for <month> input fields

Add condition handling for suggestedValue case in updateview() and preview functions.
Updated test cases accordingly.

BUG=335212
R=isherman@chromium.org, tkent@chromium.org, jhawkins@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167933

[ziran.sun, 2014-01-16 19:52:04]

Please review this in conjunction with 

https://codereview.chromium.org/140903004/

Thanks!

[tkent, 2014-01-17 01:32:35]

We should support Android too. BaseMultipleFieldsDateAndTimeInputType.cpp isn't
used in Android.

[ziran.sun, 2014-01-17 15:40:22]

On 2014/01/17 01:32:35, tkent wrote:
> We should support Android too. BaseMultipleFieldsDateAndTimeInputType.cpp
isn't
> used in Android.

I'm not sure autofill preview is supported in Android. I understand autofill
fillform works but I'm not able to see preview works in Android for any field
apart from showing suggestions to the init node. Do please correct me if I'm
wrong though.

[Ilya Sherman, 2014-02-08 01:22:17]

On 2014/01/17 15:40:22, ziran.sun wrote:
> On 2014/01/17 01:32:35, tkent wrote:
> > We should support Android too. BaseMultipleFieldsDateAndTimeInputType.cpp
> isn't
> > used in Android.
> 
> I'm not sure autofill preview is supported in Android. I understand autofill
> fillform works but I'm not able to see preview works in Android for any field
> apart from showing suggestions to the init node. Do please correct me if I'm
> wrong though.

I think you're correct for regular Autofill.  Suggested values are, AFAIK, used
for password autofill on Android, but that should never involve <input
type="month"> elements... so it's probably fine not to support Android for this.
 However, you'll probably need to do at least a bit of work for Android, since
MonthInputType is probably used on Android as well as elsewhere.

https://codereview.chromium.org/130213005/diff/1/Source/core/html/forms/BaseM...
File Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp (right):

https://codereview.chromium.org/130213005/diff/1/Source/core/html/forms/BaseM...
Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp:509: else if
(!element().formControlValueMatchesRenderer())
Why is it relevant whether the form control's value matches the renderer?  I
don't see this check having been needed before, so this is a pretty surprising
addition.

[ziran.sun, 2014-02-10 18:21:09]

Add android side code and remove unnecessary condition check. 

Thanks.

https://codereview.chromium.org/130213005/diff/1/Source/core/html/forms/BaseM...
File Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp (right):

https://codereview.chromium.org/130213005/diff/1/Source/core/html/forms/BaseM...
Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp:509: else if
(!element().formControlValueMatchesRenderer())
On 2014/02/08 01:22:18, Ilya Sherman (catching up...) wrote:
> Why is it relevant whether the form control's value matches the renderer?  I
> don't see this check having been needed before, so this is a pretty surprising
> addition.

Done.

https://codereview.chromium.org/130213005/diff/1/Source/core/html/forms/BaseM...
Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp:509: else if
(!element().formControlValueMatchesRenderer())
On 2014/02/08 01:22:18, Ilya Sherman (catching up...) wrote:
> Why is it relevant whether the form control's value matches the renderer?  I
> don't see this check having been needed before, so this is a pretty surprising
> addition.

I noticed this check in updateView() in TextFieldInputType.cpp. It probably
doesn't make sense here I guess. I've removed this check.

[ziran.sun, 2014-02-13 10:30:39]

On 2014/02/10 18:21:09, ziran.sun wrote:
> Add android side code and remove unnecessary condition check. 
> 
> Thanks.
> 
>
https://codereview.chromium.org/130213005/diff/1/Source/core/html/forms/BaseM...
> File Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp
(right):
> 
>
https://codereview.chromium.org/130213005/diff/1/Source/core/html/forms/BaseM...
> Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp:509: else if
> (!element().formControlValueMatchesRenderer())
> On 2014/02/08 01:22:18, Ilya Sherman (catching up...) wrote:
> > Why is it relevant whether the form control's value matches the renderer?  I
> > don't see this check having been needed before, so this is a pretty
surprising
> > addition.
> 
> Done.
> 
>
https://codereview.chromium.org/130213005/diff/1/Source/core/html/forms/BaseM...
> Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp:509: else if
> (!element().formControlValueMatchesRenderer())
> On 2014/02/08 01:22:18, Ilya Sherman (catching up...) wrote:
> > Why is it relevant whether the form control's value matches the renderer?  I
> > don't see this check having been needed before, so this is a pretty
surprising
> > addition.
> 
> I noticed this check in updateView() in TextFieldInputType.cpp. It probably
> doesn't make sense here I guess. I've removed this check.

Hi tkent, 

Is it okay to check if the android side code okay or not? Thanks!

[tkent, 2014-02-13 23:52:40]

lgtm

[commit-bot: I haz the power, 2014-02-13 23:52:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ziran.sun@samsung.com/130213005/80001

[Ilya Sherman, 2014-02-14 02:05:57]

LGTM with the following nits addressed.  Cancelling CQ for now, but feel free to
re-CQ with these addressed.  Thanks!

https://codereview.chromium.org/130213005/diff/80001/Source/core/html/forms/B...
File Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.cpp (right):

https://codereview.chromium.org/130213005/diff/80001/Source/core/html/forms/B...
Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.cpp:75: String
displayValue = "";
nit: "String displayValue = "";" -> "String displayValue;"

https://codereview.chromium.org/130213005/diff/80001/Source/core/html/forms/B...
Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.cpp:80: }
nit: No need for curly braces for these if/else stmt bodies, since they're each
a single line.

[Ilya Sherman, 2014-02-14 02:06:02]

The CQ bit was unchecked by isherman@chromium.org

[ziran.sun, 2014-02-14 10:25:23]

Remove unnecessary curly braces and correct variable init.

https://codereview.chromium.org/130213005/diff/80001/Source/core/html/forms/B...
File Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.cpp (right):

https://codereview.chromium.org/130213005/diff/80001/Source/core/html/forms/B...
Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.cpp:75: String
displayValue = "";
On 2014/02/14 02:05:57, Ilya Sherman wrote:
> nit: "String displayValue = "";" -> "String displayValue;"

Done.

https://codereview.chromium.org/130213005/diff/80001/Source/core/html/forms/B...
Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.cpp:80: }
On 2014/02/14 02:05:57, Ilya Sherman wrote:
> nit: No need for curly braces for these if/else stmt bodies, since they're
each
> a single line.

Done.

[Ilya Sherman, 2014-02-14 21:22:43]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2014-02-14 21:22:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ziran.sun@samsung.com/130213005/260001

[commit-bot: I haz the power, 2014-02-15 00:13:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-15 00:13:30]

Retried try job too often on win_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...

[ziran.sun, 2014-02-25 15:06:17]

The CQ bit was checked by ziran.sun@samsung.com

[commit-bot: I haz the power, 2014-02-25 15:06:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ziran.sun@samsung.com/130213005/540001

[ziran.sun, 2014-02-25 15:08:02]

The CQ bit was unchecked by ziran.sun@samsung.com

[ziran.sun, 2014-02-25 15:08:02]

The CQ bit was checked by ziran.sun@samsung.com

[ziran.sun, 2014-02-25 15:08:45]

The CQ bit was unchecked by ziran.sun@samsung.com

[ziran.sun, 2014-02-26 18:33:23]

The CQ bit was checked by ziran.sun@samsung.com

[commit-bot: I haz the power, 2014-02-26 18:33:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ziran.sun@samsung.com/130213005/690001

[commit-bot: I haz the power, 2014-02-26 22:12:23]

Change committed as 167933