Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 1302103002: VisualBenchTest: Write JSON output (Closed)

Created:
5 years, 4 months ago by borenet
Modified:
5 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M bench/ResultsWriter.h View 2 chunks +7 lines, -0 lines 0 comments Download
A platform_tools/android/apps/robotium.cfg View 1 1 chunk +7 lines, -0 lines 0 comments Download
M platform_tools/android/apps/visualbench/src/main/java/com/skia/VisualBenchTestActivity.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
borenet
https://codereview.chromium.org/1302103002/diff/1/bench/ResultsWriter.h File bench/ResultsWriter.h (right): https://codereview.chromium.org/1302103002/diff/1/bench/ResultsWriter.h#newcode125 bench/ResultsWriter.h:125: } I don't know that this is the right ...
5 years, 4 months ago (2015-08-20 14:05:16 UTC) #2
djsollen
https://codereview.chromium.org/1302103002/diff/1/platform_tools/android/apps/robotium.cfg File platform_tools/android/apps/robotium.cfg (right): https://codereview.chromium.org/1302103002/diff/1/platform_tools/android/apps/robotium.cfg#newcode1 platform_tools/android/apps/robotium.cfg:1: [robotium] what is this file for? I can guess, ...
5 years, 4 months ago (2015-08-20 14:42:35 UTC) #3
borenet
https://codereview.chromium.org/1302103002/diff/1/platform_tools/android/apps/robotium.cfg File platform_tools/android/apps/robotium.cfg (right): https://codereview.chromium.org/1302103002/diff/1/platform_tools/android/apps/robotium.cfg#newcode1 platform_tools/android/apps/robotium.cfg:1: [robotium] On 2015/08/20 14:42:35, djsollen wrote: > what is ...
5 years, 4 months ago (2015-08-20 15:32:23 UTC) #4
djsollen
lgtm
5 years, 4 months ago (2015-08-20 15:57:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1302103002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1302103002/20001
5 years, 4 months ago (2015-08-20 16:05:13 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 16:12:42 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/877a52ae61f41f0b519a906ed2460d44746de8e1

Powered by Google App Engine
This is Rietveld 408576698