Roll Clang 243039:245402

Roll Clang 243039:245402

BUG=518002
R=thakis@chromium.org
TBR=thakis

Committed: https://chromium.googlesource.com/chromium/src/+/80b78dfe1af1f4bb8fbc87e074c1f66d564e9d7a

[hans, 2015-08-20 20:41:36]

hans@chromium.org changed reviewers:
+ thakis@chromium.org

[hans, 2015-08-20 20:41:42]

The CQ bit was checked by hans@chromium.org

[commit-bot: I haz the power, 2015-08-20 20:43:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1302053002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1302053002/1

[Nico, 2015-08-20 23:36:07]

On 2015/08/20 20:43:05, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1302053002/1
> View timeline at
>  https://chromium-cq-status.appspot.com/patch-timeline/1302053002/1

Lgtm

`git cl land` time :-(

[hans, 2015-08-20 23:44:40]

Committed patchset #1 (id:1) manually as
80b78dfe1af1f4bb8fbc87e074c1f66d564e9d7a (presubmit successful).

[Adrian Kuegel, 2015-08-25 14:13:28]

akuegel@chromium.org changed reviewers:
+ akuegel@chromium.org

[Adrian Kuegel, 2015-08-25 14:13:29]

It seems this roll has made running the translation_unit tool for Codesearch
horribly slow:
https://uberchromegw.corp.google.com/i/chromium.infra.cron/builders/Chromium%...

It now takes ~8 times as long as before. Any idea what might cause this?

[Nico, 2015-08-25 15:40:57]

On 2015/08/25 14:13:29, Adrian Kuegel wrote:
> It seems this roll has made running the translation_unit tool for Codesearch
> horribly slow:
>
https://uberchromegw.corp.google.com/i/chromium.infra.cron/builders/Chromium%...
> 
> It now takes ~8 times as long as before. Any idea what might cause this?

Can you repro locally? Can you profile where the time goes? What does the
translation_unit tool do?

[Adrian Kuegel, 2015-08-25 15:43:16]

On 2015/08/25 15:40:57, Nico wrote:
> On 2015/08/25 14:13:29, Adrian Kuegel wrote:
> > It seems this roll has made running the translation_unit tool for Codesearch
> > horribly slow:
> >
>
https://uberchromegw.corp.google.com/i/chromium.infra.cron/builders/Chromium%...
> > 
> > It now takes ~8 times as long as before. Any idea what might cause this?
> 
> Can you repro locally? Can you profile where the time goes? What does the
> translation_unit tool do?

Will try that. What it does is to parse all files involved in compiling a
certain cc file, to gather the information needed to recompile it independently.

[Nico, 2015-08-25 15:47:26]

On 2015/08/25 15:43:16, Adrian Kuegel wrote:
> On 2015/08/25 15:40:57, Nico wrote:
> > On 2015/08/25 14:13:29, Adrian Kuegel wrote:
> > > It seems this roll has made running the translation_unit tool for
Codesearch
> > > horribly slow:
> > >
> >
>
https://uberchromegw.corp.google.com/i/chromium.infra.cron/builders/Chromium%...
> > > 
> > > It now takes ~8 times as long as before. Any idea what might cause this?
> > 
> > Can you repro locally? Can you profile where the time goes? What does the
> > translation_unit tool do?
> 
> Will try that. What it does is to parse all files involved in compiling a
> certain cc file, to gather the information needed to recompile it
independently.

Does it use libclang, or use clang APIs some other way? Or is it just a host
program that's built by clang? I.e. is this because clang's internal AST
handling maybe got slower, or is this because clang's codegen got worse?

(Also, probably best to file a bug for this instead of discussing this here.)