Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Side by Side Diff: sandbox/linux/bpf_dsl/bpf_dsl.cc

Issue 1302043002: sandbox/linux: refactor bpf_dsl dependency on die.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Change default panic behavior to simply Kill Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sandbox/linux/bpf_dsl/bpf_dsl.h ('k') | sandbox/linux/bpf_dsl/bpf_dsl_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "sandbox/linux/bpf_dsl/bpf_dsl.h" 5 #include "sandbox/linux/bpf_dsl/bpf_dsl.h"
6 6
7 #include <limits> 7 #include <limits>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/memory/ref_counted.h" 10 #include "base/memory/ref_counted.h"
11 #include "sandbox/linux/bpf_dsl/bpf_dsl_impl.h" 11 #include "sandbox/linux/bpf_dsl/bpf_dsl_impl.h"
12 #include "sandbox/linux/bpf_dsl/policy_compiler.h" 12 #include "sandbox/linux/bpf_dsl/policy_compiler.h"
13 #include "sandbox/linux/seccomp-bpf/die.h"
14 #include "sandbox/linux/seccomp-bpf/errorcode.h" 13 #include "sandbox/linux/seccomp-bpf/errorcode.h"
15 14
16 namespace sandbox { 15 namespace sandbox {
17 namespace bpf_dsl { 16 namespace bpf_dsl {
18 namespace { 17 namespace {
19 18
20 intptr_t BPFFailure(const struct arch_seccomp_data&, void* aux) {
21 SANDBOX_DIE(static_cast<char*>(aux));
22 }
23
24 class AllowResultExprImpl : public internal::ResultExprImpl { 19 class AllowResultExprImpl : public internal::ResultExprImpl {
25 public: 20 public:
26 AllowResultExprImpl() {} 21 AllowResultExprImpl() {}
27 22
28 ErrorCode Compile(PolicyCompiler* pc) const override { 23 ErrorCode Compile(PolicyCompiler* pc) const override {
29 return ErrorCode(ErrorCode::ERR_ALLOWED); 24 return ErrorCode(ErrorCode::ERR_ALLOWED);
30 } 25 }
31 26
32 bool IsAllow() const override { return true; } 27 bool IsAllow() const override { return true; }
33 28
(...skipping 16 matching lines...) Expand all
50 bool IsDeny() const override { return true; } 45 bool IsDeny() const override { return true; }
51 46
52 private: 47 private:
53 ~ErrorResultExprImpl() override {} 48 ~ErrorResultExprImpl() override {}
54 49
55 int err_; 50 int err_;
56 51
57 DISALLOW_COPY_AND_ASSIGN(ErrorResultExprImpl); 52 DISALLOW_COPY_AND_ASSIGN(ErrorResultExprImpl);
58 }; 53 };
59 54
55 class KillResultExprImpl : public internal::ResultExprImpl {
56 public:
57 KillResultExprImpl() {}
58
59 ErrorCode Compile(PolicyCompiler* pc) const override {
60 return ErrorCode(ErrorCode::ERR_KILL);
61 }
62
63 bool IsDeny() const override { return true; }
64
65 private:
66 ~KillResultExprImpl() override {}
67
68 DISALLOW_COPY_AND_ASSIGN(KillResultExprImpl);
69 };
70
60 class TraceResultExprImpl : public internal::ResultExprImpl { 71 class TraceResultExprImpl : public internal::ResultExprImpl {
61 public: 72 public:
62 TraceResultExprImpl(uint16_t aux) : aux_(aux) {} 73 TraceResultExprImpl(uint16_t aux) : aux_(aux) {}
63 74
64 ErrorCode Compile(PolicyCompiler* pc) const override { 75 ErrorCode Compile(PolicyCompiler* pc) const override {
65 return ErrorCode(ErrorCode::ERR_TRACE + aux_); 76 return ErrorCode(ErrorCode::ERR_TRACE + aux_);
66 } 77 }
67 78
68 private: 79 private:
69 ~TraceResultExprImpl() override {} 80 ~TraceResultExprImpl() override {}
(...skipping 199 matching lines...) Expand 10 before | Expand all | Expand 10 after
269 } // namespace internal 280 } // namespace internal
270 281
271 ResultExpr Allow() { 282 ResultExpr Allow() {
272 return ResultExpr(new const AllowResultExprImpl()); 283 return ResultExpr(new const AllowResultExprImpl());
273 } 284 }
274 285
275 ResultExpr Error(int err) { 286 ResultExpr Error(int err) {
276 return ResultExpr(new const ErrorResultExprImpl(err)); 287 return ResultExpr(new const ErrorResultExprImpl(err));
277 } 288 }
278 289
279 ResultExpr Kill(const char* msg) { 290 ResultExpr Kill() {
280 return Trap(BPFFailure, msg); 291 return ResultExpr(new const KillResultExprImpl());
281 } 292 }
282 293
283 ResultExpr Trace(uint16_t aux) { 294 ResultExpr Trace(uint16_t aux) {
284 return ResultExpr(new const TraceResultExprImpl(aux)); 295 return ResultExpr(new const TraceResultExprImpl(aux));
285 } 296 }
286 297
287 ResultExpr Trap(TrapRegistry::TrapFnc trap_func, const void* aux) { 298 ResultExpr Trap(TrapRegistry::TrapFnc trap_func, const void* aux) {
288 return ResultExpr( 299 return ResultExpr(
289 new const TrapResultExprImpl(trap_func, aux, true /* safe */)); 300 new const TrapResultExprImpl(trap_func, aux, true /* safe */));
290 } 301 }
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
356 new const IfThenResultExprImpl(clause.first, clause.second, expr)); 367 new const IfThenResultExprImpl(clause.first, clause.second, expr));
357 } 368 }
358 return expr; 369 return expr;
359 } 370 }
360 371
361 } // namespace bpf_dsl 372 } // namespace bpf_dsl
362 } // namespace sandbox 373 } // namespace sandbox
363 374
364 template class scoped_refptr<const sandbox::bpf_dsl::internal::BoolExprImpl>; 375 template class scoped_refptr<const sandbox::bpf_dsl::internal::BoolExprImpl>;
365 template class scoped_refptr<const sandbox::bpf_dsl::internal::ResultExprImpl>; 376 template class scoped_refptr<const sandbox::bpf_dsl::internal::ResultExprImpl>;
OLDNEW
« no previous file with comments | « sandbox/linux/bpf_dsl/bpf_dsl.h ('k') | sandbox/linux/bpf_dsl/bpf_dsl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698