Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 1302033004: Return failure if getInputResultsGPU fails in SkXfermodeImageFilter (Closed)

Created:
5 years, 4 months ago by robertphillips
Modified:
5 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Return failure if getInputResultsGPU fails in SkXfermodeImageFilter SkXfermodeImageFilter::filterImageGPU is the only call site that does anything fancy when getInputResultsGPU fails. It seems like we can just return like everyone else (for uniformity). Committed: https://skia.googlesource.com/skia/+/850f2d9c097575484d9438abdc3b1b8ac60d589c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/effects/SkXfermodeImageFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
robertphillips
5 years, 4 months ago (2015-08-20 19:55:19 UTC) #2
Stephen White
LGTM if the bots like it. There may be a reason I did this, but ...
5 years, 4 months ago (2015-08-20 20:42:51 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1302033004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1302033004/1
5 years, 4 months ago (2015-08-20 20:45:23 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-20 20:51:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1302033004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1302033004/1
5 years, 4 months ago (2015-08-21 15:23:50 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 15:24:26 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/850f2d9c097575484d9438abdc3b1b8ac60d589c

Powered by Google App Engine
This is Rietveld 408576698