Implement ComponentExtensionIMEManagerDelegate.

Implement ComponentExtensionIMEManagerDelegate.

Currently this class is compiled but not used.
This class reads manifest.json of component extension ime and load/unload it.

BUG=164377
TEST=None
TBR=sky

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190418

[Zachary Kuznia, 2013-03-25 06:33:05]

https://codereview.chromium.org/13020002/diff/9001/chrome/browser/chromeos/in...
File
chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc
(right):

https://codereview.chromium.org/13020002/diff/9001/chrome/browser/chromeos/in...
chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc:36:
return  extension_service->component_loader();
nit: one space after return.

https://codereview.chromium.org/13020002/diff/9001/chrome/browser/chromeos/in...
chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc:113:
IBusComponent::EngineDescription* out) {
DCHECK(BrowserThread::FILE)

https://codereview.chromium.org/13020002/diff/9001/chrome/browser/chromeos/in...
chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc:140:
ComponentExtensionIME* out) {
DCHECK(BrowserThread::FILE)

https://codereview.chromium.org/13020002/diff/9001/chrome/browser/chromeos/in...
chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc:148:
void ComponentExtentionIMEManagerImpl::ReadComponentExtensionsInfo(
DCHECK(BrowserThread::FILE)

https://codereview.chromium.org/13020002/diff/9001/chrome/browser/chromeos/in...
chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc:184:
DCHECK(result);
DCHECK(BrowserThread::UI), too.

https://codereview.chromium.org/13020002/diff/9001/chrome/browser/chromeos/in...
chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc:185:
component_extension_list_ = *result;
This is accessed on other threads, so this could be a race.

[Seigo Nonaka, 2013-03-25 09:28:50]

https://codereview.chromium.org/13020002/diff/9001/chrome/browser/chromeos/in...
File
chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc
(right):

https://codereview.chromium.org/13020002/diff/9001/chrome/browser/chromeos/in...
chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc:36:
return  extension_service->component_loader();
On 2013/03/25 06:33:05, Zachary Kuznia wrote:
> nit: one space after return.

Done.

https://codereview.chromium.org/13020002/diff/9001/chrome/browser/chromeos/in...
chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc:113:
IBusComponent::EngineDescription* out) {
On 2013/03/25 06:33:05, Zachary Kuznia wrote:
> DCHECK(BrowserThread::FILE)

Done.

https://codereview.chromium.org/13020002/diff/9001/chrome/browser/chromeos/in...
chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc:140:
ComponentExtensionIME* out) {
On 2013/03/25 06:33:05, Zachary Kuznia wrote:
> DCHECK(BrowserThread::FILE)

Done.

https://codereview.chromium.org/13020002/diff/9001/chrome/browser/chromeos/in...
chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc:148:
void ComponentExtentionIMEManagerImpl::ReadComponentExtensionsInfo(
On 2013/03/25 06:33:05, Zachary Kuznia wrote:
> DCHECK(BrowserThread::FILE)

Done.

https://codereview.chromium.org/13020002/diff/9001/chrome/browser/chromeos/in...
chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc:184:
DCHECK(result);
On 2013/03/25 06:33:05, Zachary Kuznia wrote:
> DCHECK(BrowserThread::UI), too.

Done.

https://codereview.chromium.org/13020002/diff/9001/chrome/browser/chromeos/in...
chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc:185:
component_extension_list_ = *result;
|component_extension_list_| is accessed on only UI thread.
And |result| is only referred from OnReadComponentExtensionsInfo and
ReadComponentExtensionsInfo. And they are called with PostTaskAndReply, so it is
guaranteed that OnReadComponentExtensionsInfo accesses after
ReadComponentExtensionsInfo is finished.
On 2013/03/25 06:33:05, Zachary Kuznia wrote:
> This is accessed on other threads, so this could be a race.

[Zachary Kuznia, 2013-03-25 09:43:52]

lgtm

[Seigo Nonaka, 2013-03-25 12:07:12]

TBR-ing for gypi file.

[commit-bot: I haz the power, 2013-03-25 12:07:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nona@chromium.org/13020002/15001

[commit-bot: I haz the power, 2013-03-25 16:31:30]

Change committed as 190418