Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 13020002: Implement ComponentExtensionIMEManagerDelegate. (Closed)

Created:
7 years, 9 months ago by Seigo Nonaka
Modified:
7 years, 9 months ago
Reviewers:
Zachary Kuznia
CC:
chromium-reviews, nkostylev+watch_chromium.org, Aaron Boodman, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Implement ComponentExtensionIMEManagerDelegate. Currently this class is compiled but not used. This class reads manifest.json of component extension ime and load/unload it. BUG=164377 TEST=None TBR=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190418

Patch Set 1 : #

Total comments: 12

Patch Set 2 : Addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+295 lines, -3 lines) Patch
A chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.h View 1 chunk +91 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc View 1 1 chunk +198 lines, -0 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chromeos/ime/component_extension_ime_manager.h View 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Seigo Nonaka
7 years, 9 months ago (2013-03-25 05:57:05 UTC) #1
Zachary Kuznia
https://codereview.chromium.org/13020002/diff/9001/chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc File chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc (right): https://codereview.chromium.org/13020002/diff/9001/chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc#newcode36 chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc:36: return extension_service->component_loader(); nit: one space after return. https://codereview.chromium.org/13020002/diff/9001/chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc#newcode113 chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc:113: ...
7 years, 9 months ago (2013-03-25 06:33:05 UTC) #2
Seigo Nonaka
https://codereview.chromium.org/13020002/diff/9001/chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc File chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc (right): https://codereview.chromium.org/13020002/diff/9001/chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc#newcode36 chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc:36: return extension_service->component_loader(); On 2013/03/25 06:33:05, Zachary Kuznia wrote: > ...
7 years, 9 months ago (2013-03-25 09:28:50 UTC) #3
Zachary Kuznia
lgtm
7 years, 9 months ago (2013-03-25 09:43:52 UTC) #4
Seigo Nonaka
TBR-ing for gypi file.
7 years, 9 months ago (2013-03-25 12:07:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/13020002/15001
7 years, 9 months ago (2013-03-25 12:07:35 UTC) #6
commit-bot: I haz the power
7 years, 9 months ago (2013-03-25 16:31:30 UTC) #7
Message was sent while issue was closed.
Change committed as 190418

Powered by Google App Engine
This is Rietveld 408576698