Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4980)

Unified Diff: Source/modules/accessibility/InspectorAccessibilityAgent.cpp

Issue 1301993003: Last few steps of text alternative computation algorithm (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Testing all the special cases Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/accessibility/InspectorAccessibilityAgent.cpp
diff --git a/Source/modules/accessibility/InspectorAccessibilityAgent.cpp b/Source/modules/accessibility/InspectorAccessibilityAgent.cpp
index 68b5a477dc35880fc69d6c55d048af8ce316f406..e33ccf23f7dbb269e61215d73f6762c38ef68961 100644
--- a/Source/modules/accessibility/InspectorAccessibilityAgent.cpp
+++ b/Source/modules/accessibility/InspectorAccessibilityAgent.cpp
@@ -126,11 +126,6 @@ bool roleAllowsSort(AccessibilityRole role)
return role == ColumnHeaderRole || role == RowHeaderRole;
}
-bool roleAllowsRangeValues(AccessibilityRole role)
-{
- return role == ProgressIndicatorRole || role == ScrollBarRole || role == SliderRole || role == SpinButtonRole;
-}
-
bool roleAllowsChecked(AccessibilityRole role)
{
return role == MenuItemCheckBoxRole || role == MenuItemRadioRole || role == RadioButtonRole || role == CheckBoxRole || role == TreeItemRole || role == ListBoxOptionRole || role == SwitchRole;
@@ -194,7 +189,7 @@ void fillWidgetProperties(AXObject* axObject, PassRefPtr<TypeBuilder::Array<AXPr
// TODO(aboxhall): sort
}
- if (roleAllowsRangeValues(role)) {
+ if (axObject->isRange()) {
properties->addItem(createProperty(AXWidgetAttributes::Valuemin, createValue(axObject->minValueForRange())));
properties->addItem(createProperty(AXWidgetAttributes::Valuemax, createValue(axObject->maxValueForRange())));
properties->addItem(createProperty(AXWidgetAttributes::Valuetext, createValue(axObject->valueDescription())));

Powered by Google App Engine
This is Rietveld 408576698