Source/modules/accessibility/AXNodeObject.h - Issue 1301993003: Last few steps of text alternative computation algorithm

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/accessibility/AXNodeObject.h

Issue 1301993003: Last few steps of text alternative computation algorithm (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Testing all the special cases Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/accessibility/name-calc-native-markup-input-buttons.html ('K') | « LayoutTests/accessibility/name-calc-summary.html ('k') | Source/modules/accessibility/AXNodeObject.cpp » ('j') | Source/modules/accessibility/AXNodeObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/accessibility/AXNodeObject.h

diff --git a/Source/modules/accessibility/AXNodeObject.h b/Source/modules/accessibility/AXNodeObject.h

index 1d43500650665d2aa7d9b46229874a4469a33736..046d571dc9b50e3c928a19735827c184dcee08a7 100644

--- a/Source/modules/accessibility/AXNodeObject.h

+++ b/Source/modules/accessibility/AXNodeObject.h

@@ -168,7 +168,7 @@ protected:

String computedName() const override;

// New AX name calculation.

- String textAlternative(bool recursive, bool inAriaLabelledByTraversal, AXObjectSet& visited, AXNameFrom&, AXObjectVector& nameObjects, NameSources*) const override;

+ String textAlternative(bool recursive, bool inAriaLabelledByTraversal, AXObjectSet& visited, AXNameFrom&, AXObjectVector* nameObjects, NameSources*) const override;

// Location and click point in frame-relative coordinates.

LayoutRect elementRect() const override;

@@ -217,9 +217,9 @@ private:

void deprecatedAriaLabelledbyText(WillBeHeapVector<OwnPtrWillBeMember<AccessibilityText>>&) const;

String textFromDescendants(AXObjectSet& visited) const;

- String textFromElements(bool inAriaLabelledByTraversal, AXObjectSet& visited, WillBeHeapVector<RawPtrWillBeMember<Element>>& elements, AXObjectVector& nameObjects) const;

- String textFromAriaLabelledby(AXObjectSet& visited, AXObjectVector& nameObjects) const;

- String nativeTextAlternative(AXObjectSet& visited, AXNameFrom&, AXObjectVector& nameObjects, NameSources*, bool* foundTextAlternative) const;

+ String textFromElements(bool inAriaLabelledByTraversal, AXObjectSet& visited, WillBeHeapVector<RawPtrWillBeMember<Element>>& elements, AXObjectVector* nameObjects) const;

+ String textFromAriaLabelledby(AXObjectSet& visited, AXObjectVector* nameObjects) const;

+ String nativeTextAlternative(AXObjectSet& visited, AXNameFrom&, AXObjectVector* nameObjects, NameSources*, bool* foundTextAlternative) const;

float stepValueForRange() const;

AXObject* findChildWithTagName(const HTMLQualifiedName&) const;

bool isDescendantOfElementType(const HTMLQualifiedName& tagName) const;