Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1301953002: WebMessaging: Show a warning when MessagePort attempts to send a transferable ArrayBuffer (Closed)

Created:
5 years, 4 months ago by nhiroki
Modified:
5 years, 4 months ago
Reviewers:
kinuko, haraken
CC:
blink-reviews, blink-reviews-dom_chromium.org, vivekg_samsung, sof, eae+blinkwatch, vivekg, dglazkov+blink, blink-reviews-bindings_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

WebMessaging: Show a warning when MessagePort attempts to send a transferable ArrayBuffer In the current implementation, MessagePort does not support sending an ArrayBuffer as a transferable object yet and unexpectedly loses the buffer without any warning. BUG=334408 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200832

Patch Set 1 #

Total comments: 2

Patch Set 2 : add const / update test expectation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M LayoutTests/fast/events/message-port-clone-expected.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/core/v8/SerializedScriptValue.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M Source/bindings/core/v8/SerializedScriptValue.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/dom/MessagePort.cpp View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
nhiroki
PTAL, thanks!
5 years, 4 months ago (2015-08-19 09:34:37 UTC) #2
kinuko
lgtm
5 years, 4 months ago (2015-08-19 12:02:24 UTC) #3
haraken
bindings/ LGTM https://codereview.chromium.org/1301953002/diff/1/Source/bindings/core/v8/SerializedScriptValue.h File Source/bindings/core/v8/SerializedScriptValue.h (right): https://codereview.chromium.org/1301953002/diff/1/Source/bindings/core/v8/SerializedScriptValue.h#newcode101 Source/bindings/core/v8/SerializedScriptValue.h:101: bool containsTransferableArrayBuffer(); Add const.
5 years, 4 months ago (2015-08-19 12:10:40 UTC) #5
nhiroki
Thank you! https://codereview.chromium.org/1301953002/diff/1/Source/bindings/core/v8/SerializedScriptValue.h File Source/bindings/core/v8/SerializedScriptValue.h (right): https://codereview.chromium.org/1301953002/diff/1/Source/bindings/core/v8/SerializedScriptValue.h#newcode101 Source/bindings/core/v8/SerializedScriptValue.h:101: bool containsTransferableArrayBuffer(); On 2015/08/19 12:10:40, haraken wrote: ...
5 years, 4 months ago (2015-08-19 12:59:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301953002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301953002/20001
5 years, 4 months ago (2015-08-19 16:12:12 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 16:44:51 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200832

Powered by Google App Engine
This is Rietveld 408576698