Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(934)

Unified Diff: Source/core/editing/Position.h

Issue 1301933002: Move a static member function nodeIsUserSelectNone() out from PositionAlgorithm template class (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-08-19T17:33:44 Move out from class Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/editing/Position.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/Position.h
diff --git a/Source/core/editing/Position.h b/Source/core/editing/Position.h
index b953e1c8a073c2ea217aebd0fcd94a2d6c933196..b91a806547fc36566c6470b71ecae9fea0edbc56 100644
--- a/Source/core/editing/Position.h
+++ b/Source/core/editing/Position.h
@@ -200,7 +200,6 @@ public:
InlineBoxPosition computeInlineBoxPosition(EAffinity, TextDirection primaryDirection) const;
static bool hasRenderedNonAnonymousDescendantsWithHeight(LayoutObject*);
- static bool nodeIsUserSelectNone(Node*);
static bool nodeIsUserSelectAll(const Node*);
static Node* rootUserSelectAllForNode(Node*);
static PositionAlgorithm<Strategy> beforeNode(Node* anchorNode);
@@ -445,6 +444,8 @@ inline PositionInComposedTree fromPositionInDOMTree<EditingInComposedTreeStrateg
return toPositionInComposedTree(position);
}
+CORE_EXPORT bool nodeIsUserSelectNone(Node*);
tkent 2015/08/19 09:24:04 Is Position.{h,cpp} the best home of nodeIsUserSel
yosin_UTC9 2015/08/19 09:34:18 No. Following patch will move it to "EditingUtilit
tkent 2015/08/19 09:41:08 I prefer moving it to EditingUtilities in this CL.
yosin_UTC9 2015/08/19 09:59:32 Done.
+
} // namespace blink
#ifndef NDEBUG
« no previous file with comments | « no previous file | Source/core/editing/Position.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698