Move a static member function nodeIsUserSelectNone() out from PositionAlgorithm template class

Move a static member function nodeIsUserSelectNone() out from PositionAlgorithm template class

This patch moves |nodeIsUserSelectNone()| out from |PositionAlgorithm| template
class to "EditingUtilities.{cpp,h}" to simplify |PositionAlgorithm| class for
improving code health, since |nodeIsUserSelectNone()| doesn't depend on
|Strategy| template parameter.

BUG=518738
TEST=n/a; no behavior changes

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200822

[yosin_UTC9, 2015-08-19 08:38:24]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-19 08:38:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1301933002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1301933002/1

[yosin_UTC9, 2015-08-19 09:11:11]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org

[yosin_UTC9, 2015-08-19 09:11:12]

PTAL

[tkent, 2015-08-19 09:24:04]

https://codereview.chromium.org/1301933002/diff/1/Source/core/editing/Position.h
File Source/core/editing/Position.h (right):

https://codereview.chromium.org/1301933002/diff/1/Source/core/editing/Positio...
Source/core/editing/Position.h:447: CORE_EXPORT bool
nodeIsUserSelectNone(Node*);
Is Position.{h,cpp} the best home of nodeIsUserSelectNone()?
HTMLLabelElement doesn't refer to Position except
Position::nodeIsUserSelectNone(). 
SelectionController::updateSelectionForMouseDownDispatchingSelectStart() doesn't
use Position objects.

[yosin_UTC9, 2015-08-19 09:33:53]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-19 09:34:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1301933002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1301933002/20001

[yosin_UTC9, 2015-08-19 09:34:18]

PTAL

Add comments about new home of nodeIsUserSelectNone().

https://codereview.chromium.org/1301933002/diff/1/Source/core/editing/Position.h
File Source/core/editing/Position.h (right):

https://codereview.chromium.org/1301933002/diff/1/Source/core/editing/Positio...
Source/core/editing/Position.h:447: CORE_EXPORT bool
nodeIsUserSelectNone(Node*);
On 2015/08/19 09:24:04, tkent wrote:
> Is Position.{h,cpp} the best home of nodeIsUserSelectNone()?
> HTMLLabelElement doesn't refer to Position except
> Position::nodeIsUserSelectNone(). 
> SelectionController::updateSelectionForMouseDownDispatchingSelectStart()
doesn't
> use Position objects.
No. Following patch will move it to "EditingUtilities.{cpp,h}".

[tkent, 2015-08-19 09:41:08]

https://codereview.chromium.org/1301933002/diff/1/Source/core/editing/Position.h
File Source/core/editing/Position.h (right):

https://codereview.chromium.org/1301933002/diff/1/Source/core/editing/Positio...
Source/core/editing/Position.h:447: CORE_EXPORT bool
nodeIsUserSelectNone(Node*);
On 2015/08/19 09:34:18, Yosi_UTC9 wrote:
> On 2015/08/19 09:24:04, tkent wrote:
> > Is Position.{h,cpp} the best home of nodeIsUserSelectNone()?
> > HTMLLabelElement doesn't refer to Position except
> > Position::nodeIsUserSelectNone(). 
> > SelectionController::updateSelectionForMouseDownDispatchingSelectStart()
> doesn't
> > use Position objects.
> No. Following patch will move it to "EditingUtilities.{cpp,h}".

I prefer moving it to EditingUtilities in this CL.

[yosin_UTC9, 2015-08-19 09:59:17]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[yosin_UTC9, 2015-08-19 09:59:32]

PTAL

Move to EditingUtilitis.{cpp.h}

https://codereview.chromium.org/1301933002/diff/1/Source/core/editing/Position.h
File Source/core/editing/Position.h (right):

https://codereview.chromium.org/1301933002/diff/1/Source/core/editing/Positio...
Source/core/editing/Position.h:447: CORE_EXPORT bool
nodeIsUserSelectNone(Node*);
On 2015/08/19 09:41:08, tkent wrote:
> On 2015/08/19 09:34:18, Yosi_UTC9 wrote:
> > On 2015/08/19 09:24:04, tkent wrote:
> > > Is Position.{h,cpp} the best home of nodeIsUserSelectNone()?
> > > HTMLLabelElement doesn't refer to Position except
> > > Position::nodeIsUserSelectNone(). 
> > > SelectionController::updateSelectionForMouseDownDispatchingSelectStart()
> > doesn't
> > > use Position objects.
> > No. Following patch will move it to "EditingUtilities.{cpp,h}".
> 
> I prefer moving it to EditingUtilities in this CL.
> 

Done.

[commit-bot: I haz the power, 2015-08-19 09:59:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1301933002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1301933002/40001

[tkent, 2015-08-19 10:06:24]

lgtm

[commit-bot: I haz the power, 2015-08-19 11:25:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-19 11:25:05]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2015-08-19 12:56:01]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2015-08-19 12:56:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1301933002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1301933002/40001

[commit-bot: I haz the power, 2015-08-19 13:00:09]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200822