Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1046)

Unified Diff: sync/sessions/sync_session_unittest.cc

Issue 130193002: sync: Consistently refcount ModelSafeWorkers (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix standalone sync client Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/sessions/sync_session_context.cc ('k') | sync/tools/sync_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/sessions/sync_session_unittest.cc
diff --git a/sync/sessions/sync_session_unittest.cc b/sync/sessions/sync_session_unittest.cc
index e712552f580679d48d753d5010495583d7f0df18..f341f38e3a2a9db9812cd8a3c26bb4e965603637 100644
--- a/sync/sessions/sync_session_unittest.cc
+++ b/sync/sessions/sync_session_unittest.cc
@@ -51,14 +51,11 @@ class SyncSessionTest : public testing::Test,
workers_.push_back(ui_worker);
workers_.push_back(db_worker);
- std::vector<ModelSafeWorker*> workers;
- GetWorkers(&workers);
-
context_.reset(
new SyncSessionContext(
NULL,
NULL,
- workers,
+ workers_,
extensions_activity_.get(),
std::vector<SyncEngineEventListener*>(),
NULL,
@@ -109,13 +106,6 @@ class SyncSessionTest : public testing::Test,
FailControllerInvocationIfDisabled("SyncProtocolError");
}
- void GetWorkers(std::vector<ModelSafeWorker*>* out) const {
- out->clear();
- for (std::vector<scoped_refptr<ModelSafeWorker> >::const_iterator it =
- workers_.begin(); it != workers_.end(); ++it) {
- out->push_back(it->get());
- }
- }
void GetModelSafeRoutingInfo(ModelSafeRoutingInfo* out) const {
*out = routes_;
}
« no previous file with comments | « sync/sessions/sync_session_context.cc ('k') | sync/tools/sync_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698