sync/internal_api/sync_manager_impl_unittest.cc - Issue 130193002: sync: Consistently refcount ModelSafeWorkers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/sync_manager_impl_unittest.cc

Issue 130193002: sync: Consistently refcount ModelSafeWorkers (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix standalone sync client Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/internal_api/sync_manager_impl_unittest.cc

diff --git a/sync/internal_api/sync_manager_impl_unittest.cc b/sync/internal_api/sync_manager_impl_unittest.cc

index c8d5817620eb50ea921511c5e66d2c3065e4b9e5..57e2a5bdbe496f627ae78b894ae1c6333ecd936a 100644

--- a/sync/internal_api/sync_manager_impl_unittest.cc

+++ b/sync/internal_api/sync_manager_impl_unittest.cc

@@ -813,7 +813,7 @@ class SyncManagerTest : public testing::Test,

EXPECT_FALSE(js_backend_.IsInitialized());

- std::vector<ModelSafeWorker*> workers;

+ std::vector<scoped_refptr<ModelSafeWorker> > workers;

ModelSafeRoutingInfo routing_info;

GetModelSafeRoutingInfo(&routing_info);

@@ -821,7 +821,7 @@ class SyncManagerTest : public testing::Test,

// If we had types in other groups, we would need additional workers

// to support them.

scoped_refptr<ModelSafeWorker> worker = new FakeModelWorker(GROUP_PASSIVE);

- workers.push_back(worker.get());

+ workers.push_back(worker);

// Takes ownership of |fake_invalidator_|.

sync_manager_.Init(

« no previous file with comments | « sync/internal_api/sync_manager_impl.cc ('k') | sync/internal_api/test/fake_sync_manager.cc » ('j') | no next file with comments »